[IMP] intergrate gh tool #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisdoan
force-pushed
the
intergrate-with-gh
branch
from
167ddf7 to
aad9cce
Compare
sebalix
reviewed
Dec 16, 2024
oca_port/app.py
Outdated
Comment on lines
113
to
125
| token = False | ||
| if os.environ.get("GITHUB_TOKEN"): | ||
| token = os.environ["GITHUB_TOKEN"] | ||
| else: | ||
| token = self.github_token | ||
| if not token: | ||
| try: | ||
| # get from gh | ||
| token = subprocess.check_output( | ||
| ["gh", "auth", "token"], text=True | ||
| ).strip() | ||
| except subprocess.SubprocessError: | ||
| pass |
There was a problem hiding this comment.
This code doesn't match the explanation in README: it takes in priority the token from env, then from the parameter, and from gh. I propose the following to give the priority to the parameter first, then env, and gh:
Suggested change
| token = False | |
| if os.environ.get("GITHUB_TOKEN"): | |
| token = os.environ["GITHUB_TOKEN"] | |
| else: | |
| token = self.github_token | |
| if not token: | |
| try: | |
| # get from gh | |
| token = subprocess.check_output( | |
| ["gh", "auth", "token"], text=True | |
| ).strip() | |
| except subprocess.SubprocessError: | |
| pass | |
| token = self.github_token | |
| if not token: | |
| token = os.environ.get("GITHUB_TOKEN") | |
| if not token: | |
| try: | |
| # get from gh | |
| token = subprocess.check_output( | |
| ["gh", "auth", "token"], text=True | |
| ).strip() | |
| except subprocess.SubprocessError: | |
| pass |
There was a problem hiding this comment.
We could even consolidate this token resolution in a dedicated method
trisdoan
force-pushed
the
intergrate-with-gh
branch
from
aad9cce to
92dd5c4
Compare
trisdoan
force-pushed
the
intergrate-with-gh
branch
from
92dd5c4 to
45b117c
Compare
trisdoan
force-pushed
the
intergrate-with-gh
branch
from
45b117c to
64c5ea7
Compare
sebalix
approved these changes
Dec 20, 2024
|
@trisdoan ready to merge? |
|
Thank you for this contribution, really appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.