PortAddonPullRequest: reduce noise by filtering PRs to port #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #21
PRs that are updating both the analyzed module + other ones (here called 'satellite') were listed by
oca-port
, even if the commits related to the analyzed module were already ported, because contributions on these satellite modules were not (yet) ported.In the context of the analyzed module, this brings noise and such PR should not be proposed to be ported, but only mentioned.
There are now two kinds of detected PRs:
oca-port
on them.As such PRs with commits updating only satellite modules are not proposed anymore to the user, some modules will now be considered as "Fully ported" instead of still having some "Commits to port", which is accurate from a reporting POV 🎉
Example of interactive output on
shopfloor_mobile
fromOCA/wms
:Example of JSON output on
stock_storage_type
fromOCA/wms
:$ oca-port origin/14.0 origin/16.0 stock_storage_type --verbose --dry-run --output=json | jq .
Before
After
{} # Now considered as "Fully ported"
Still in
OCA/wms
repository, forshopfloor
module this reduces the number of PRs to port from 34 to 11.TODO