Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] base_location_nuts: CI is failing #1557

Closed
fernandahf opened this issue Aug 3, 2023 · 6 comments
Closed

[14.0] base_location_nuts: CI is failing #1557

fernandahf opened this issue Aug 3, 2023 · 6 comments
Labels

Comments

@fernandahf
Copy link

fernandahf commented Aug 3, 2023

Currently, CI in version 14.0 is failing because of this error:

2023-06-14 18:12:34,649 251 INFO odoo odoo.addons.base_location_nuts.wizard.nuts_import: Download successfully 183248 bytes 
2023-06-14 18:12:34,657 251 INFO odoo unittest.suite: ====================================================================== 
2023-06-14 18:12:34,657 251 ERROR odoo unittest.suite: ERROR: setUpClass (odoo.addons.base_location_nuts.tests.test_base_location_nuts.TestBaseLocationNuts)
Traceback (most recent call last):
  File "/opt/odoo/odoo/tests/common.py", line 173, in _handleClassSetUp
    setUpClass()
  File "/__w/partner-contact/partner-contact/base_location_nuts/tests/test_base_location_nuts.py", line 13, in setUpClass
    cls.importer.run_import()  # loads nuts
  File "/__w/partner-contact/partner-contact/base_location_nuts/wizard/nuts_import.py", line 213, in run_import
    xmlcontent = self._download_nuts()
  File "/__w/partner-contact/partner-contact/base_location_nuts/wizard/nuts_import.py", line 154, in _download_nuts
    raise UserError(_("Downloaded file is not a valid XML file"))
odoo.exceptions.UserError: Downloaded file is not a valid XML file

https://github.com/OCA/partner-contact/actions/runs/5270637894/job/14266154719#step:8:450

Module

base_location_nuts

Describe the bug

CI failing because of an error processing a file.

To Reproduce

14.0

Expected behavior
No error in CI

@LoisRForgeFlow
Copy link
Contributor

This issue is affecting all open PRs in v14 and v15 right now.

@pedrobaeza
Copy link
Member

It seems the file is no longer there. We should find a replacement. You can disable for now the tests (although the module is also not working on the initial import) for not blocking.

@rafaelbn
Copy link
Member

Solved @LoisRForgeFlow ?

@ypapouin
Copy link
Contributor

Any idea why this issue is still there for OCA/crm#491 ?
https://github.com/OCA/crm/actions/runs/5939004985/job/16104557807?pr=491#step:8:111

Is that normal that oca_dependencies.txt for 14.0 does not include partner-contact when crm_location_nuts depends on base_location_nuts ?

@LoisRForgeFlow
Copy link
Contributor

Any idea why this issue is still there for OCA/crm#491 ? https://github.com/OCA/crm/actions/runs/5939004985/job/16104557807?pr=491#step:8:111

Is that normal that oca_dependencies.txt for 14.0 does not include partner-contact when crm_location_nuts depends on base_location_nuts ?

oca_dependencies.txt are deprecated with the newer oca-ci, in which dependencies from other repos are fetched from pip.

@ypapouin
Copy link
Contributor

Thank you, indeed I can now see that a wheel is downloaded.

Looking at the exception, the issue comes from the fact that crm_location_nuts re-use the test class from base_location_nuts.
I'm preparing a PR to disable the test.

SergiCForgeFlow pushed a commit to ForgeFlow/partner-contact that referenced this issue Oct 19, 2023
NL66278 pushed a commit to Therp/partner-contact that referenced this issue Nov 6, 2023
edlopen pushed a commit to moduon/partner-contact that referenced this issue May 27, 2024
salvorapi pushed a commit to salvorapi/partner-contact that referenced this issue Jul 5, 2024
anusriNPS pushed a commit to PyTech-SRL/partner-contact that referenced this issue Jul 15, 2024
salvorapi pushed a commit to salvorapi/partner-contact that referenced this issue Jul 22, 2024
salvorapi pushed a commit to salvorapi/partner-contact that referenced this issue Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants