Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][TEMP] base_location_nuts: do not run tests as it makes all CI pipelines to fail #1559

Merged
merged 1 commit into from
Aug 10, 2023
Merged

[15.0][TEMP] base_location_nuts: do not run tests as it makes all CI pipelines to fail #1559

merged 1 commit into from
Aug 10, 2023

Conversation

LoisRForgeFlow
Copy link
Contributor

Issue details: #1557

@pedrobaeza
Copy link
Member

pedrobaeza commented Aug 10, 2023 •
edited
Loading

Instead of doing that, which also excludes POT/README regeneration, just comment the import in the __init__.py file of the tests folder.

@LoisRForgeFlow LoisRForgeFlow force-pushed the 15.0-temp-fix-exclude-base_location_nuts branch from 21c4011 to 13e784a Compare August 10, 2023 14:54
@LoisRForgeFlow LoisRForgeFlow changed the title [15.0][TEMP] exclude "base_location_nuts" as it makes all pipelines to fail [15.0][TEMP] base_location_nuts: do not run tests as it makes all CI pipelines to fail Aug 10, 2023
@LoisRForgeFlow
Copy link
Contributor Author

Instead of doing that, which also excludes POT/README regeneration, just comment the import in the __init__.py file of the tests folder.

@pedrobaeza Changed!

@pedrobaeza pedrobaeza added this to the 15.0 milestone Aug 10, 2023
pedrobaeza
pedrobaeza approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's greenify the branch

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1559-by-pedrobaeza-bump-patch, awaiting test results.

@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Aug 10, 2023
Merged
@OCA-git-bot OCA-git-bot merged commit df7413f into OCA:15.0 Aug 10, 2023
5 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9fe343f. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 15.0-temp-fix-exclude-base_location_nuts branch August 10, 2023 15:05
@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LoisRForgeFlow @pedrobaeza @OCA-git-bot