Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] partner_contact_personal_information_page #1377

Merged

Conversation

marielejeune
Copy link
Contributor

No description provided.

Jairo Llopis and others added 30 commits October 10, 2022 14:59
Really I'm just renaming partner_contact_base.
The new name is more self-explanatory.
…#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10
- fax field removed from res.partner
- 2to3 on all py files
- add contributor and update README
- use hasclass in place of @Class in xpath expr
- improve tests

[FIX] typo and clean README
Currently translated at 100.0% (1 of 1 strings)

Translation: partner-contact-11.0/partner-contact-11.0-partner_contact_personal_information_page
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-partner_contact_personal_information_page/da/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-12.0/partner-contact-12.0-partner_contact_personal_information_page
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_personal_information_page/
Currently translated at 100.0% (1 of 1 strings)

Translation: partner-contact-14.0/partner-contact-14.0-partner_contact_personal_information_page
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_contact_personal_information_page/hu/
@oca-clabot
Copy link

Hey @marielejeune, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@marielejeune
Copy link
Contributor Author

#1353

Copy link
Contributor

@PierrickBrun PierrickBrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review + test

Copy link
Contributor

@AnizR AnizR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review

@rousseldenis
Copy link
Contributor

/ocabot migration partner_contact_personal_information_page

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 10, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 10, 2022
60 tasks
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NL66278
Copy link
Contributor

NL66278 commented Oct 11, 2022

Fasttracking this, as it is a base for other modules and a straight migration.

/ocabot merge patch
/ocabot migration partner_contact_personal_information_page

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1377-by-NL66278-bump-patch, awaiting test results.

@carmenbianca
Copy link
Member

@NL66278 Do we rebase all the other open PRs on top of the new 16.0 when this is merged?

@OCA-git-bot OCA-git-bot merged commit 8757a54 into OCA:16.0 Oct 11, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c09717a. Thanks a lot for contributing to OCA. ❤️

@NL66278
Copy link
Contributor

NL66278 commented Oct 11, 2022

@carmenbianca I think the modules that depend on partner_contact_personal_information_page should be rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.