-
-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] partner_contact_personal_information_page #1377
[16.0] [MIG] partner_contact_personal_information_page #1377
Conversation
Really I'm just renaming partner_contact_base. The new name is more self-explanatory.
…#315) [MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10
- fax field removed from res.partner - 2to3 on all py files - add contributor and update README - use hasclass in place of @Class in xpath expr - improve tests [FIX] typo and clean README
Currently translated at 100.0% (1 of 1 strings) Translation: partner-contact-11.0/partner-contact-11.0-partner_contact_personal_information_page Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-partner_contact_personal_information_page/da/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-12.0/partner-contact-12.0-partner_contact_personal_information_page Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_personal_information_page/
Currently translated at 100.0% (1 of 1 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_contact_personal_information_page Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_contact_personal_information_page/hu/
Currently translated at 100.0% (1 of 1 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_contact_personal_information_page Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_contact_personal_information_page/pt/
Currently translated at 100.0% (1 of 1 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_contact_personal_information_page Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_contact_personal_information_page/ca/
Hey @marielejeune, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review + test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review
/ocabot migration partner_contact_personal_information_page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fasttracking this, as it is a base for other modules and a straight migration. /ocabot merge patch |
On my way to merge this fine PR! |
@NL66278 Do we rebase all the other open PRs on top of the new 16.0 when this is merged? |
Congratulations, your PR was merged at c09717a. Thanks a lot for contributing to OCA. ❤️ |
@carmenbianca I think the modules that depend on partner_contact_personal_information_page should be rebased. |
No description provided.