[MIG] partner_identification: Migration to 15.0 #1436

jdidderen-noviat · 2022-12-26T23:28:36Z

Since the PR #1270 seems to be (almost) abandoned, I backported the work done by @marielejeune for v16 in the PR #1397

rousseldenis · 2023-01-20T16:43:28Z

/ocabot migration partner_identification

rousseldenis · 2023-01-20T16:46:41Z

@jdidderen-noviat Thanks for this.

Could you follow migration guide ? https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

Especially the Full process part (inversing branches in git format-patch command) ?

You must keep commit authorship from @marielejeune ones

njeudy

code and test

njeudy · 2023-01-21T07:26:00Z

I think @marielejeune do the work in V16 and here we patch from v14 .. so .. he add marielejeune as contributor .. that ok for me I think :)

* [IMP] improve module description * [IMP] Remove useless comments * [FIX] Complete incomplete sentence * [IMP] Replace field 'state' by 'status' in res_partner_id_number * [IMP] Add new field 'Place of Issuance' * [FIX] Readme formatting * [IMP] status is now a selection field * [IMP] use method to provide the default value for validation_code * [IMP] Add help texts * [FIX] Add missing constrains on category_id in res_partner.id_number The number must be validated also when we change the category

Allow for context override of validations using ``id_no_validate``

OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option

[FIX] Tests [FIX] data sequence Fix openerp to odoo in comment [REM] at_install, post_install [ADD] Model descriptions [REM] Extra spaces

Currently translated at 97.9% (46 of 47 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_identification/it/

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-12.0/partner-contact-12.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_identification/

Currently translated at 97.9% (46 of 47 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_identification/es/

jdidderen-noviat · 2023-02-05T21:39:52Z

@rousseldenis Sorry for the delay. I was a bit silly when I did this PR. I did the format patch from 14.0 to 15.0 and then cherry pick the changes from @marielejeune instead of format patching from 16.0 to 15.0

@njeudy It was exactly that.

Thanks for the reviews :)

OCA-git-bot · 2023-02-10T11:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

NL66278 · 2023-03-06T16:20:54Z

@jdidderen-noviat Please squash some of the translation commits (for instance the consecutive ones for Croatian or Italian).

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-16.0/partner-contact-16.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_identification/ Translated using Weblate (Italian) Currently translated at 87.7% (43 of 49 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_identification/it/ Translated using Weblate (Italian) Currently translated at 87.7% (43 of 49 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_identification/it/ Translated using Weblate (Croatian) Currently translated at 30.6% (15 of 49 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_identification/hr/ Translated using Weblate (Croatian) Currently translated at 51.0% (25 of 49 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_identification/hr/

jdidderen-noviat · 2023-03-06T18:04:25Z

@NL66278 Done

MiquelRForgeFlow · 2023-03-28T11:20:09Z

partner_identification/__manifest__.py

+{
+    "name": "Partner Identification Numbers",
+    "category": "Customer Relationship Management",
+    "version": "15.0.1.0.1",


Suggested change

"version": "15.0.1.0.1",

"version": "15.0.1.0.0",

@MiquelRForgeFlow The change is applied. Thanks for the review :)

dreispt · 2023-03-31T17:01:40Z

/ocabot merge nobump

OCA-git-bot · 2023-03-31T17:01:46Z

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1436-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

OCA-git-bot · 2023-03-31T17:11:21Z

It looks like something changed on 15.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 15.0-ocabot-merge-pr-1436-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot · 2023-03-31T17:21:39Z

Congratulations, your PR was merged at 6799d94. Thanks a lot for contributing to OCA. ❤️

jdidderen-noviat mentioned this pull request Jan 13, 2023

[15.0][MIG] 10n_be_partner_kbo_bce OCA/l10n-belgium#179

Merged

njeudy mentioned this pull request Jan 19, 2023

[15.0] [MIG] partner_identification and partner_identification_gln #1454

Closed

OCA-git-bot added this to the 15.0 milestone Jan 20, 2023

rousseldenis added needs review migration labels Jan 20, 2023

OCA-git-bot mentioned this pull request Jan 20, 2023

Migration to version 15.0 #1153

Open

68 tasks

njeudy approved these changes Jan 21, 2023

View reviewed changes

lmignon and others added 20 commits February 5, 2023 22:26

[IMP] Rename partner_identifiers -> partner_identification

c5230f9

[FIX] partner_identification: prevent integrity error on delete ID

ab590f0

[ADD] partner_identification: sales_team dep

3ec1da5

[FIX] partner_identification: pylint

8ef4c6e

[IMP] partner_identification: Add context override (OCA#373)

e251ed2

Allow for context override of validations using ``id_no_validate``

[FIX] partner_identification: Infinite loop in search (OCA#436)

e51df44

OCA Transbot updated translations from Transifex

dca25cd

[11.0][MIG] partner_identification

f531238

partner_identification: fix/imp tests on res.partner

f16edf7

[UPD] Update partner_identification.pot

37eb08d

[MIG] partner_identification: Migration to 12.0

707d972

[FIX] Tests [FIX] data sequence Fix openerp to odoo in comment [REM] at_install, post_install [ADD] Model descriptions [REM] Extra spaces

[UPD] README.rst

ff56eb6

[UPD] Update partner_identification.pot

7eb6f96

Update translation files

0933b32

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] Update partner_identification.pot

9113c0e

oca-ci and others added 3 commits February 5, 2023 22:26

[UPD] Update partner_identification.pot

3760971

[UPD] README.rst

bf5fe7d

partner_identification 16.0.1.0.1

dda23fa

jdidderen-noviat force-pushed the 15.0-mig-partner_identification branch from 6073506 to 7e447ab Compare February 5, 2023 21:35

rousseldenis approved these changes Feb 10, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Feb 10, 2023

badbole and others added 2 commits March 6, 2023 19:00

[IMP] partner_identification: black, isort, prettier

eb562c7

jdidderen-noviat force-pushed the 15.0-mig-partner_identification branch from 7e447ab to 49bc193 Compare March 6, 2023 18:01

JasminSForgeFlow mentioned this pull request Mar 28, 2023

[15.0][MIG] account_multi_vat OCA/account-fiscal-rule#358

Merged

MiquelRForgeFlow reviewed Mar 28, 2023

View reviewed changes

LoisRForgeFlow approved these changes Mar 28, 2023

View reviewed changes

[MIG] partner_identification: Migration to 15.0

52a463b

jdidderen-noviat force-pushed the 15.0-mig-partner_identification branch from 49bc193 to 52a463b Compare March 28, 2023 12:21

MiquelRForgeFlow approved these changes Mar 28, 2023

View reviewed changes

dreispt mentioned this pull request Mar 31, 2023

[15.0][MIG] partner_identification #1270

Closed

OCA-git-bot added the bot is merging ⏳ label Mar 31, 2023

OCA-git-bot added a commit that referenced this pull request Mar 31, 2023

Merge PR #1436 into 15.0

c8d63ff

Signed-off-by dreispt

OCA-git-bot merged commit 101247a into OCA:15.0 Mar 31, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] partner_identification: Migration to 15.0 #1436

[MIG] partner_identification: Migration to 15.0 #1436

jdidderen-noviat commented Dec 26, 2022 •

edited

Loading

rousseldenis commented Jan 20, 2023

rousseldenis commented Jan 20, 2023

njeudy left a comment

njeudy commented Jan 21, 2023 •

edited

Loading

jdidderen-noviat commented Feb 5, 2023

OCA-git-bot commented Feb 10, 2023

NL66278 commented Mar 6, 2023

jdidderen-noviat commented Mar 6, 2023

MiquelRForgeFlow Mar 28, 2023

jdidderen-noviat Mar 28, 2023

dreispt commented Mar 31, 2023

OCA-git-bot commented Mar 31, 2023

OCA-git-bot commented Mar 31, 2023

OCA-git-bot commented Mar 31, 2023

[MIG] partner_identification: Migration to 15.0 #1436

[MIG] partner_identification: Migration to 15.0 #1436

Conversation

jdidderen-noviat commented Dec 26, 2022 • edited Loading

rousseldenis commented Jan 20, 2023

rousseldenis commented Jan 20, 2023

njeudy left a comment

Choose a reason for hiding this comment

njeudy commented Jan 21, 2023 • edited Loading

jdidderen-noviat commented Feb 5, 2023

OCA-git-bot commented Feb 10, 2023

NL66278 commented Mar 6, 2023

jdidderen-noviat commented Mar 6, 2023

MiquelRForgeFlow Mar 28, 2023

Choose a reason for hiding this comment

jdidderen-noviat Mar 28, 2023

Choose a reason for hiding this comment

dreispt commented Mar 31, 2023

OCA-git-bot commented Mar 31, 2023

OCA-git-bot commented Mar 31, 2023

OCA-git-bot commented Mar 31, 2023

jdidderen-noviat commented Dec 26, 2022 •

edited

Loading

njeudy commented Jan 21, 2023 •

edited

Loading