-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] partner helper + rename it partner_address_split #1543
[16.0][MIG] partner helper + rename it partner_address_split #1543
Conversation
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
* Migrate to V10 * Tests * Remove method args not necessary with new api
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-12.0/partner-contact-12.0-partner_helper Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_helper/
Currently translated at 100.0% (1 of 1 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_helper Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_helper/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-14.0/partner-contact-14.0-partner_helper Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_helper/
Currently translated at 100.0% (1 of 1 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_helper Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_helper/pt_BR/
/ocabot migration partner_helper |
The migration issue (#1353) has been updated to reference the current pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a lot
This PR has the |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 8f8ba12. Thanks a lot for contributing to OCA. ❤️ |
@bealdav @rousseldenis Better late than never, I made the changes we talked about here : #1412
So, rename the module + add tests to improve coverage.
Finally, I have decided making a new PR because I want to keep the
partner_helper
original migration branch because this module is already used in production. and need to be kept until a clean transition is made. I'll close this old PR though.