Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] partner helper + rename it partner_address_split #1543

Merged
merged 27 commits into from
Jul 5, 2023

Conversation

florian-dacosta
Copy link
Contributor

@bealdav @rousseldenis Better late than never, I made the changes we talked about here : #1412
So, rename the module + add tests to improve coverage.

Finally, I have decided making a new PR because I want to keep the partner_helper original migration branch because this module is already used in production. and need to be kept until a clean transition is made. I'll close this old PR though.

bealdav and others added 27 commits November 23, 2022 17:45
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
* Migrate to V10
* Tests
* Remove method args not necessary with new api
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-12.0/partner-contact-12.0-partner_helper
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_helper/
Currently translated at 100.0% (1 of 1 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_helper
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_helper/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-14.0/partner-contact-14.0-partner_helper
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_helper/
Currently translated at 100.0% (1 of 1 strings)

Translation: partner-contact-14.0/partner-contact-14.0-partner_helper
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_helper/pt_BR/
@rousseldenis
Copy link
Contributor

/ocabot migration partner_helper

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 16, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 16, 2023
60 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#1353) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1412.
Perhaps you should check that there is no duplicate work.
CC : @florian-dacosta

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bguillot
Copy link

bguillot commented Jul 5, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1543-by-bguillot-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4e3207b into OCA:16.0 Jul 5, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8f8ba12. Thanks a lot for contributing to OCA. ❤️

@bealdav bealdav deleted the 16.0-mig-rename-partner_helper branch July 5, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.