Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] partner_employee_quantity #1687

Merged
merged 39 commits into from
Mar 13, 2024
Merged

[16.0] [MIG] partner_employee_quantity #1687

merged 39 commits into from
Mar 13, 2024

Conversation

edlopen
Copy link
Member

@edlopen edlopen commented Mar 4, 2024 •
edited by yajo
Loading

I only added the commits of this stale PR and changed the module icon to the OCA one.

@moduon MT-1749

Please @Shide @yajo @EmilioPascual @rafaelbn please review, if you can.

Closes #1526

@yajo yajo added this to the 16.0 milestone Mar 6, 2024
yajo
yajo requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing Git history before the rename (see 1st commit, which comes from #225). This module had several renames and we should respect all that history in the migration if possible.

Apart from that, it's OK.

/ocabot migration partner_employee_quantity

@OCA-git-bot
Copy link
Contributor

The migration issue (#1353) has not been updated to reference the current pull request because a previous pull request (#1526) is not closed.
Perhaps you should check that there is no duplicate work.
CC @SoporteOperu

Antonio Espinosa and others added 24 commits March 6, 2024 10:23
@edlopen
[ADD] crm_employees addon
5d6cdb3
@edlopen
Set some fields as tranlate
dd79ad7
@edlopen
Employees range items has no parent
ffe3f8c
@edlopen
[FIX] XML revised
d39a29b
@edlopen
[FIX] View fields review
2f4acd4
@edlopen
[FIX] Add new record on top of the list
4d2e00d
@edlopen
[IMP] Updated translations
57e00ea
@antespi @edlopen
Renaming several views to complain best practices
6c8fe53
@yajo @edlopen
Rename module to partner_employee_amount.
0bd6226
@yajo @edlopen
Prepare for OCA.
a0b7c29 
- Shorter copyright & license headers.
- Remove all CRM functionality & dependencies.
- Move fields to Sales & Purchases tab.
- Remove pot.
- Probably something more.
@yajo @edlopen
Rename to partner_employee_quantity.
dc302ed
@yajo @edlopen
Improve metadata.
52c3c7f
@yajo @edlopen
Move group of fields outside unrelated Sales & Purchases tab.
cd08a61
@oca-transbot @edlopen
OCA Transbot updated translations from Transifex
106fbb6
@oca-transbot @edlopen
OCA Transbot updated translations from Transifex
be5bfb9
@oca-transbot @edlopen
OCA Transbot updated translations from Transifex
2cac8bc
@oca-transbot @edlopen
OCA Transbot updated translations from Transifex
5b80351
@oca-transbot @edlopen
OCA Transbot updated translations from Transifex
ed0d9f7
@oca-transbot @edlopen
OCA Transbot updated translations from Transifex
57a524f
@sbidoul @edlopen
[FIX] remove en.po that was erroneously created by transbot
5cb33a1
@oca-transbot @edlopen
OCA Transbot updated translations from Transifex
b5bcf08
@oca-travis @edlopen
[UPD] Update partner_employee_quantity.pot
49b8b9f
@mvrodriguez @edlopen
Translated using Weblate (Spanish)
470fdca 
Currently translated at 100.0% (16 of 16 strings)

Translation: partner-contact-8.0/partner-contact-8.0-partner_employee_quantity
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-8-0/partner-contact-8-0-partner_employee_quantity/es/
@francesco-ooops @edlopen
Translated using Weblate (Italian)
fac7f16 
Currently translated at 43.7% (7 of 16 strings)

Translation: partner-contact-8.0/partner-contact-8.0-partner_employee_quantity
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-8-0/partner-contact-8-0-partner_employee_quantity/it/
pedrobaeza and others added 13 commits March 6, 2024 10:50
@edlopen
partner_employee_quantity: Migration to 11.0
3c9b787 
* Standard procedure
* Adapt dependencies
* Adapt menu
* Improve view layout
* README by fragments
* Rise to mature status with maintainer myself
@Nikul-Chaudhary @edlopen
[MIG] partner_employee_quantity v11 to v12
8fa05f4
@newtratip @edlopen
[IMP] partner_employee_quantity: black, isort
9e0915a
@newtratip @edlopen
[13.0][MIG] partner_employee_quantity
c504703
@newtratip @edlopen
[MIG] partner_employee_quantity: Migration to 14.0
4d61d40
@cesar-tecnativa @edlopen
[MIG] partner_employee_quantity: Migration to 15.0
9b52dd6
@edlopen
[UPD] Update partner_employee_quantity.pot
18747ec
@OCA-git-bot @edlopen
[UPD] README.rst
0a2c81d
@francesco-ooops @edlopen
Translated using Weblate (Italian)
b4dcc13 
Currently translated at 53.3% (8 of 15 strings)

Translation: partner-contact-15.0/partner-contact-15.0-partner_employee_quantity
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_employee_quantity/it/
@mymage @edlopen
Translated using Weblate (Italian)
672a156 
Currently translated at 53.3% (8 of 15 strings)

Translation: partner-contact-15.0/partner-contact-15.0-partner_employee_quantity
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_employee_quantity/it/
@sysadminmatmoz @edlopen
Translated using Weblate (Slovenian)
0d23377 
Currently translated at 93.3% (14 of 15 strings)

Translation: partner-contact-15.0/partner-contact-15.0-partner_employee_quantity
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_employee_quantity/sl/
@edlopen
[IMP] partner_employee_quantity: black, isort, prettier
5458725
@edlopen
[MIG] partner_employee_quantity: Migration to 16.0
e4e7553
@edlopen edlopen force-pushed the 16.0-mig-partner_employee_quantity branch from 923dcad to e01091e Compare March 6, 2024 09:52
@edlopen edlopen force-pushed the 16.0-mig-partner_employee_quantity branch from e01091e to 8d024a2 Compare March 6, 2024 10:02
fcvalgar
fcvalgar approved these changes Mar 12, 2024
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.

LGTM, Thank you @edlopen

image

image

image

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@yajo
Copy link
Member

yajo commented Mar 13, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1687-by-yajo-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a8a0081 into OCA:16.0 Mar 13, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 07865a7. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 16.0-mig-partner_employee_quantity branch March 13, 2024 09:37
@rafaelbn rafaelbn mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcvalgar fcvalgar fcvalgar approved these changes

@yajo yajo yajo approved these changes

Assignees

@edlopen edlopen

Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.