[17.0] [MIG] product_configurator_mrp_component #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UPD] Updated code with working items. [UPD] Improved logic and added config component domain [UPD] Added readme and default qty [UPD] pre-commit [UPD] pre-commit [UPD] pre-commit Allow search config component by internal ref Update product_configurator_mrp_component/models/mrp_bom_line_config.py pre-commit [ADD] Added filter change configurable component availability Changes the logic of the configurable components domain. It now first checks that the child has all the attributes on the parent, and if so it then makes sure that the child has all the values for that line in the parent. This should allow a child which can have more values then the parent to still be added as a configurable component. Co-Authored-By: Daniel Reis <[email protected]>
[IMP] made so normal variants don't show exception
1. Fixes issue where if config component only has a few values in an attribute and the parent selects the values that the comp doesn't have, then don't create and add the component. This was causing an error because it was trying to create the variant even if the value selected didn't apply to the config component. This will allow more flexibility with config components. 2. Fixes issue where the available config components that show in the drop down will allow if the first attribute only had a few of the values but any attribute below that would have to have all the values in order for it to show.
Travis failed due to singleton error while
Nikul-OSI
force-pushed
the
17.0_mig_product_configurator_mrp_component
branch
from
688b3c6
to
e5787e4
Compare
Nikul-OSI
force-pushed
the
17.0_mig_product_configurator_mrp_component
branch
from
e5787e4
to
fd70bb6
Compare
|
/ocabot migration product_configurator_mrp_component |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.