Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] project_task_description_template: new module #1147

Merged

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Jul 4, 2023

Proposed changes

New module to manage description templates for project tasks

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have updated the necessary documentation

@alan196 alan196 force-pushed the 15.0-project_task_description_template branch from fca7ec6 to de51adf Compare July 4, 2023 00:24
@ygol
Copy link
Contributor

ygol commented Jul 8, 2023

getting error on runbot when calling a template in a task.

Traceback (most recent call last):
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
    result = request.dispatch()
  File "/opt/odoo/odoo/http.py", line 698, in dispatch
    result = self._call_function(**self.params)
  File "/opt/odoo/odoo/http.py", line 368, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/opt/odoo/odoo/service/model.py", line 94, in wrapper
    return f(dbname, *args, **kwargs)
  File "/opt/odoo/odoo/http.py", line 357, in checked_call
    result = self.endpoint(*a, **kw)
  File "/opt/odoo/odoo/http.py", line 921, in __call__
    return self.method(*args, **kw)
  File "/opt/odoo/odoo/http.py", line 546, in response_wrap
    response = f(*args, **kw)
  File "/opt/odoo/addons/web/controllers/main.py", line 1324, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/addons/web/controllers/main.py", line 1316, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 464, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 451, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/odoo/models.py", line 6486, in onchange
    record._onchange_eval(name, field_onchange[name], result)
  File "/opt/odoo/odoo/models.py", line 6219, in _onchange_eval
    method_res = method(self)
  File "/mnt/data/odoo-addons-dir/project_task_description_template/models/project_task.py", line 15, in _onchange_description_template_id
    self.description += self.description_template_id.description
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 654, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/opt/odoo/odoo/http.py", line 301, in _handle_exception
    raise exception.with_traceback(None) from new_cause
TypeError: unsupported operand type(s) for +=: 'bool' and 'Markup'

@alan196 alan196 force-pushed the 15.0-project_task_description_template branch from de51adf to 79cb756 Compare August 2, 2023 12:58
@alan196
Copy link
Contributor Author

alan196 commented Aug 2, 2023

@ygol Thanks for the review! I just fixed the issue.

Could you help me to review again. 🙏

@alan196
Copy link
Contributor Author

alan196 commented Aug 2, 2023

@EduardoJarsa Could you help me to review this PR 🙏

Copy link

@EduardoJarsa EduardoJarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, everything looks working

Copy link
Contributor

@ygol ygol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan196 alan196 force-pushed the 15.0-project_task_description_template branch from 79cb756 to e557198 Compare October 5, 2023 20:28
@alan196 alan196 force-pushed the 15.0-project_task_description_template branch from e557198 to 2812d76 Compare October 5, 2023 20:29
@alan196
Copy link
Contributor Author

alan196 commented Oct 5, 2023

@OCA/project-service-maintainers Could you help me to review or merge this PR 🙏

@dreispt
Copy link
Member

dreispt commented Oct 10, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1147-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cca56a0 into OCA:15.0 Oct 10, 2023
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4263bf8. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 15.0-project_task_description_template branch May 4, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants