Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][IMP] project_milestone: enable chatter #1287

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[12.0][IMP] project_milestone: enable chatter #1287

merged 1 commit into from
Sep 3, 2024

Conversation

lanto-razafindrabe
Copy link

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @patrickrwilson,
some modules you are maintaining are being modified, check this out!

@majouda
Copy link

majouda commented May 24, 2024

Hello @patrickrwilson
Can you please review and merge this PR?

Thank you!

@TumbaoJu
Copy link

TumbaoJu commented Jun 6, 2024

@OCA/project-service-maintainers Hello! Could you please take a look at this PR? It would be much appreciated.
Thank you!

@TumbaoJu
Copy link

TumbaoJu commented Jun 6, 2024

Thank you @dreispt !

alexey-pelykh
alexey-pelykh requested changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s an improvement rather than new module so IMP not ADD:

[IMP] project_milestone: enable chatter

project_milestone/__manifest__.py Outdated Show resolved Hide resolved
@lanto-razafindrabe lanto-razafindrabe changed the title [12.0][ADD] Enable chatter on project milestone form [12.0][ADD] project_milestone: Enable chatter on project milestone form Aug 7, 2024
alexey-pelykh
alexey-pelykh approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@alexey-pelykh
Copy link
Contributor

@lanto-razafindrabe please squash the changes into a single commit

@lanto-razafindrabe
[ADD] Enable chatter on project milestone form
81c01f2 
[CHG] project_milestone : module version
@TumbaoJu
Copy link

TumbaoJu commented Sep 3, 2024

@OCA/project-service-maintainers : Can this PR be merge? Can someone do it? Thank you very much.
@lanto-razafindrabe @majouda : FYI

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Sponsor Member

dreispt commented Sep 3, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-1287-by-dreispt-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 66f8ade into OCA:12.0 Sep 3, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a3517f7. Thanks a lot for contributing to OCA. ❤️

@TumbaoJu
Copy link

TumbaoJu commented Sep 3, 2024

@dreispt : Thank you! ;)
@lanto-razafindrabe @majouda : PR merged!

@lanto-razafindrabe lanto-razafindrabe changed the title [12.0][ADD] project_milestone: Enable chatter on project milestone form [12.0][IMP] project_milestone: enable chatter Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

@dreispt dreispt dreispt approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lanto-razafindrabe @OCA-git-bot @majouda @TumbaoJu @alexey-pelykh @dreispt