Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] purchase_request: not allow to edit an approved purchase request #2489

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Dec 16, 2024

This commit fixes the the following issue.

  • Create a purchase request with some products and send it to approval
  • The manager approves the purchase request.
  • After the approval the user can add new products to the request and can abuse

This commit fixes the the following issue.

- Create a purchase request with some products and send it to approval
- The manager approves the purchase request.
- After the approval the user can add new products to the request and can abuse
@alan196
Copy link
Contributor Author

alan196 commented Dec 16, 2024

@AaronHForgeFlow Could you help me to review this PR 🙏

This was already fixed in 15.0 and 16.0 but now with the change in states in field definition, this change needs to be appllied to the view

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I remember this is already in previous versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants