Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] purchase_order_archive: Migration to 18.0 #2495

Open
wants to merge 33 commits into
base: 18.0
Choose a base branch
from

Conversation

HeliconiaSolutions
Copy link

No description provided.

astirpe and others added 30 commits December 19, 2024 15:49
Currently translated at 100.0% (3 of 3 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_archive
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_archive/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_order_archive
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_order_archive/
Currently translated at 100.0% (4 of 4 strings)

Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_order_archive
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_order_archive/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_archive
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_archive/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_archive
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_archive/
Currently translated at 100.0% (4 of 4 strings)

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_archive
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_archive/it/
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not your fault, but this module seems to have a pretty bad flaw: you can only archive a cancelled or locked order, but once archived you can set the cancelled order to draft and confirm it etc. etc.
Would you consider adding a constraint that prevents archived orders in any other states than cancel or done? If you do, a simple test would be good to have as well.

@HeliconiaSolutions HeliconiaSolutions force-pushed the 18.0-mig-purchase_order_archive branch from b1c5e1c to b28324d Compare December 20, 2024 05:09
@HeliconiaSolutions
Copy link
Author

@StefanRijnhart , Thank you for pointing this out and for the valuable suggestion! I've implemented a constraint to prevent archived orders from being in states other than "cancel" or "done." I’ve also added a simple test case to validate this behavior.

I’d greatly appreciate it if you could review the changes and let me know if there's anything else to improve.

Thank you again for your input!

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.