Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tool: oca-repo-add-branch #20

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Conversation

simahawk
Copy link
Contributor

Addresses 2 items of the usual flow to setup new Odoo version's branches:

  • add new branch to all repos
  • set it as default

Result for v18 OCA/repo-maintainer-conf#36

@simahawk
Copy link
Contributor Author

I still have to address the use case to reuse answers from previous branch OCA/maintainer-tools#541

@simahawk
Copy link
Contributor Author

To fix: preserve master branch defaults for tools' repo.

@simahawk
Copy link
Contributor Author

To fix: preserve master branch defaults for tools' repo.

Fixed here b3b1425

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 49.57%. Comparing base (cd396fb) to head (a1c3f47).

Files with missing lines Patch % Lines
oca_repo_maintainer/cli/manage.py 0.00% 7 Missing ⚠️
oca_repo_maintainer/tools/utils.py 84.61% 1 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   45.01%   49.57%   +4.56%     
==========================================
  Files           5        6       +1     
  Lines         311      355      +44     
  Branches       59       66       +7     
==========================================
+ Hits          140      176      +36     
- Misses        162      169       +7     
- Partials        9       10       +1     
Files with missing lines Coverage Δ
oca_repo_maintainer/cli/pages.py 0.00% <ø> (ø)
oca_repo_maintainer/tools/conf_file_manager.py 100.00% <100.00%> (ø)
oca_repo_maintainer/tools/utils.py 88.13% <84.61%> (-1.67%) ⬇️
oca_repo_maintainer/cli/manage.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@simahawk
Copy link
Contributor Author

@etobella when you have time... ;)

@rousseldenis
Copy link

@etobella

@simahawk simahawk merged commit a2ed3da into OCA:master Sep 30, 2024
3 checks passed
@simahawk
Copy link
Contributor Author

The files are ready on the conf. If we have to fix something we can do it manually there. This is just a manual tool to edit files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants