Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] base_report_to_printer: Add neutralization queries #328

Merged
merged 1 commit into from
Jul 28, 2023
Merged

[16.0][IMP] base_report_to_printer: Add neutralization queries #328

merged 1 commit into from
Jul 28, 2023

Conversation

micheledic
Copy link

Before this PR

There is no way to neutralize printers and printer server using neutralization function

After this PR

Since 16.0 of codebase there is a new function "Neutralization" that runs all neutralization queries that basically deactivate ir_cron, ir_mail_server and other production stuff. With this PR i ADD neutralization queries that deactivates printing server and printer during neutralization .

@micheledic micheledic force-pushed the 16.0-add_neutralization_queries branch from 486ceb9 to 57d08e1 Compare May 26, 2023 07:06
@micheledic
Copy link
Author

The first check is failed but not caused by my change

@micheledic
Copy link
Author

@nilshamerlinck @pedrobaeza @MiquelRForgeFlow

@MiquelRForgeFlow
Copy link
Contributor

The first check is failed but not caused by my change

Yes, it is.

Selection_1348

@micheledic
Copy link
Author

The first check is failed but not caused by my change

Yes, it is.

Selection_1348

hello,
the neutralization queries are not declared in any files so it is correct that it is not used from manifest. That error can be ignored

Since odoo 16.0 , the neutralization queries are declared inside data path and the neutralization function scans every "data" folder of the modules to check the existence of .sql .

@micheledic micheledic force-pushed the 16.0-add_neutralization_queries branch 2 times, most recently from f94096e to 20dd272 Compare May 29, 2023 09:24
yajo added a commit to moduon/oca-addons-repo-template that referenced this pull request May 30, 2023
@yajo
build(pylint-odoo): bump for v16
8b94883 
Fixes the problem explained in OCA/report-print-send#328 (comment).
@yajo yajo mentioned this pull request May 30, 2023
Merged
yajo added a commit to moduon/oca-addons-repo-template that referenced this pull request May 30, 2023
@yajo
build(pylint-odoo): bump for v16
3d83994 
Fixes the problem explained in OCA/report-print-send#328 (comment).
@MiquelRForgeFlow
Copy link
Contributor

@micheledic could you rebase?

@MiquelRForgeFlow
Copy link
Contributor

I mean, maybe we should update the copier template.

@micheledic micheledic force-pushed the 16.0-add_neutralization_queries branch from 20dd272 to fd87865 Compare July 25, 2023 10:33
@micheledic
Copy link
Author

@micheledic could you rebase?

hello, rebased!

@micheledic
Copy link
Author

@MiquelRForgeFlow error in pre-commit

@MiquelRForgeFlow
Copy link
Contributor

MiquelRForgeFlow commented Jul 25, 2023 •
edited
Loading

I mean, maybe we should update the copier template.

Then do copier -f update

@micheledic micheledic force-pushed the 16.0-add_neutralization_queries branch 2 times, most recently from 0ccaaca to 2173aef Compare July 25, 2023 11:46
@micheledic
Copy link
Author

micheledic commented Jul 25, 2023 •
edited
Loading

I mean, maybe we should update the copier template.

Then do copier -f update

Sorry the files keeps remaining untouched also after copier -f update...

@micheledic micheledic force-pushed the 16.0-add_neutralization_queries branch 2 times, most recently from 9af0747 to a778eef Compare July 25, 2023 12:12
@micheledic
Copy link
Author

micheledic commented Jul 25, 2023 •
edited
Loading

Every time i run the update, this appears and the files remains untouched

odoo@odoo-VirtualBox:~/report-print-send$ copier update -f --UNSAFE
Updating to template version 1.14.2

Copying from template version 1.14.2
 identical  .
 identical  .copier-answers.yml
 identical  .prettierrc.yml
 identical  .eslintrc.yml
  conflict  .pre-commit-config.yaml
 overwrite  .pre-commit-config.yaml
 identical  .github
 identical  .github/workflows
 identical  .github/workflows/test.yml
 identical  .github/workflows/stale.yml
 identical  .github/workflows/pre-commit.yml
  conflict  README.md
 overwrite  README.md
    create  .t2d.yml
 identical  .editorconfig
 identical  .pylintrc
 identical  .isort.cfg
 identical  .gitignore
 identical  LICENSE
 identical  .pylintrc-mandatory
 identical  .flake8

 > Running task 1 of 1: rm -f .travis.yml .t2d.yml

@micheledic micheledic force-pushed the 16.0-add_neutralization_queries branch 2 times, most recently from d3a474f to c4da9f7 Compare July 26, 2023 14:47
@yajo yajo mentioned this pull request Jul 27, 2023
Closed
@yajo
Copy link
Member

yajo commented Jul 27, 2023

It seems a bug in pylint-odoo: OCA/pylint-odoo#464

zamberjo pushed a commit to aurestic/oca-addons-repo-template that referenced this pull request Jul 27, 2023
@yajo @zamberjo
build(pylint-odoo): bump for v16
bfc6e3d 
Fixes the problem explained in OCA/report-print-send#328 (comment).
@micheledic
Copy link
Author

Bumped version of template with PR #334

than i try to rebase and check the errors

@micheledic micheledic force-pushed the 16.0-add_neutralization_queries branch from c4da9f7 to 9f2a529 Compare July 27, 2023 12:06
@micheledic
Copy link
Author

Rebased (so it has the new 1.15.0 copier template #334 ) and all checks ok! @pedrobaeza @MiquelRForgeFlow

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jul 28, 2023
@pedrobaeza
Copy link
Member

Just a minor nitpicking: this is not [ADD], but [IMP], as you are adding a feature inside an existing module, not adding a module.

@micheledic
Copy link
Author

Just a minor nitpicking: this is not [ADD], but [IMP], as you are adding a feature inside an existing module, not adding a module.

should i change the commit message ?

@pedrobaeza
Copy link
Member

It would be good

@micheledic micheledic force-pushed the 16.0-add_neutralization_queries branch 2 times, most recently from 7f20bbf to 2b64243 Compare July 28, 2023 07:59
@micheledic micheledic force-pushed the 16.0-add_neutralization_queries branch from 2b64243 to 0cd8602 Compare July 28, 2023 08:00
@micheledic
Copy link
Author

It would be good

done! sorry for before i was migrating printer_zpl2 #335 and i have pushed to the wrong branch

@pedrobaeza pedrobaeza changed the title [ADD] base_report_to_printer: Add neutralization queries [16.0][IMP] base_report_to_printer: Add neutralization queries Jul 28, 2023
@pedrobaeza
Copy link
Member

Thanks

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-328-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 72770ac into OCA:16.0 Jul 28, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cf53b65. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moylop260 moylop260 moylop260 left review comments

@yajo yajo yajo left review comments

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@micheledic @MiquelRForgeFlow @yajo @pedrobaeza @OCA-git-bot @moylop260