Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 add fastapi auth #404

Open
wants to merge 49 commits into
base: 16.0
Choose a base branch
from

Conversation

sebastienbeau
Copy link
Member

Introduce a new authentication based on partner, you can use it instead of external auth provider like keycloak

This module is linked to fastapi (it can maybe more generic in futur version).

@simahawk
Copy link
Contributor

simahawk commented Jan 5, 2024

@sebastienbeau If I'm not mistaken this work origins from https://github.com/akretion/rest-authenticable.
I don't get why it has been reworked as strictly tied to fastapi. IMO beside the routers this is something that should stay in a basic module as you did before.

BTW happy new year :)

@sebastienbeau
Copy link
Member Author

Yes it come from here.
Indeed we can split the module in two (generic, and specific to fastapi), I have hesitated
As base_rest is going to died and I do not see other case of using an alternative auth, I choose to depend on fastapi to avoid to split too much the code.
If we have case where the "base" code can be reuse I can resplit it.

@simahawk
Copy link
Contributor

to avoid to split too much the code.

AFAIS 95% of the code would be in the standalone module, only a fraction goes into fastapi integration.

If we have case where the "base" code can be reuse I can resplit it.

IMO is better to rollback to the other approach before you start spreading it 😉

In 4 years, when @lmignon will refactor these apis on the next api framework you'll thank yourself 😜

@sebastienbeau
Copy link
Member Author

Thanks for your feedback, we are going to re-split the module, @paradoxxxzero will work on it.

@paradoxxxzero
Copy link
Contributor

This PR depends on #438

@lmignon
Copy link
Contributor

lmignon commented Sep 19, 2024

I'll fix the error into the extendable-pydantic lib

@lmignon
Copy link
Contributor

lmignon commented Sep 19, 2024

@paradoxxxzero The compatibility issue is now fixed into extendable-pydantic... You've one failing test 😏

@bguillot bguillot force-pushed the 16.0-add-fastapi-auth branch 2 times, most recently from b7069de to bf1fd2c Compare September 24, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants