Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] rma: fix returned quantity in picking return wizard #420

Draft
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

sbejaoui
Copy link
Contributor

fixes: #418

@OCA-git-bot
Copy link
Contributor

Hi @chienandalu, @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@sbejaoui sbejaoui changed the title [FIX] rma: fix returned quantity in picking return wizard [16.0][FIX] rma: fix returned quantity in picking return wizard Aug 28, 2024
@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 28, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, this provokes some side effects in the "assign" method, not letting to fetch quants freely, but not sure if it applies here. Check also the effect in the delivered quantity, forecast, and so on.

@sbejaoui
Copy link
Contributor Author

AFAIK, this provokes some side effects in the "assign" method, not letting to fetch quants freely, but not sure if it applies here. Check also the effect in the delivered quantity, forecast, and so on.

Quant reservation is restricted by the original move when the source location is internal. However, this restriction is not applied if the source location is a supplier location.

For the quantities on the sale order, a move is considered only if it's linked to the sale line. BTW, I pushed a commit to allow this link if we want to have a standard refund after RMA reception.

@pedrobaeza
Copy link
Member

What happens if you have RMA reception in several steps? I think this won't be correct in that case.

@sbejaoui
Copy link
Contributor Author

What happens if you have RMA reception in several steps? I think this won't be correct in that case.

I will add a test to be sure

@sbejaoui sbejaoui marked this pull request as draft September 17, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rma: The returned quantity is not correctly computed when a reception is created through RMA
3 participants