[16.0][ADD] website_sale_loyalty_suggestion_wizard_multi_gift: New Module #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pilarvargas-tecnativa
force-pushed
the
16.0-add-website_sale_loyalty_suggestion_wizard_multi_gift
branch
from
c92edbd to
8873474
Compare
pilarvargas-tecnativa
force-pushed
the
16.0-add-website_sale_loyalty_suggestion_wizard_multi_gift
branch
from
8873474 to
7001873
Compare
carlos-lopez-tecnativa
suggested changes
Dec 16, 2024
Comment on lines
+24
to
+39
| t-call="website_sale_loyalty_suggestion_wizard.promotion_wizard_reward_product" | ||
| > | ||
| <t | ||
| t-set="reward_qty" | ||
| t-value="multi_gift_line.reward_product_quantity" | ||
| /> | ||
| <t t-set="product" t-value="product" /> | ||
| <t t-set="id" t-value="multi_gift_line.id" /> | ||
| <t | ||
| t-set="optional_product" | ||
| t-value="len(multi_gift_line.reward_product_ids) > 1" | ||
| /> | ||
| <t | ||
| t-set="option_checked" | ||
| t-value="product == multi_gift_line.reward_product_ids[:1]" | ||
| /> |
There was a problem hiding this comment.
Maybe in another module or in this one, but I think it could be useful to add the product name including attributes to differentiate between variants. What do you think?
There was a problem hiding this comment.
Done!
chienandalu
reviewed
Dec 17, 2024
Comment on lines
12
to
15
| for i in range(len(selected_product_ids)): | ||
| wizard_id.loyalty_gift_line_ids[i].selected_gift_id = int( | ||
| selected_product_ids[i] | ||
| ) |
There was a problem hiding this comment.
This loop feels a little bit weird. Without knowing the precise internals I'd say you could better use zip for the task.
There was a problem hiding this comment.
done, thanks!
When setting up a multi-gift promotion or even in a simple promotion, showing the product name without differentiating that it may be a variant, the customer does not know exactly what gift they are receiving. To avoid this confusion and also when choosing alternatives in a multi-gift promotion, the full name is shown with its attributes but omitting the reference.
pilarvargas-tecnativa
force-pushed
the
16.0-add-website_sale_loyalty_suggestion_wizard_multi_gift
branch
from
cfc03e9 to
50b2686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT48349
@chienandalu @carlos-lopez-tecnativa please review