[17.0][MIG] sale_coupon_criteria_order_based #228

mmequignon · 2024-10-21T09:28:37Z

No description provided.

Currently translated at 100.0% (10 of 10 strings) Translation: sale-promotion-14.0/sale-promotion-14.0-sale_coupon_criteria_order_based Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-14-0/sale-promotion-14-0-sale_coupon_criteria_order_based/it/

TT38306

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-promotion-15.0/sale-promotion-15.0-sale_coupon_criteria_order_based Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-15-0/sale-promotion-15-0-sale_coupon_criteria_order_based/

Currently translated at 85.7% (6 of 7 strings) Translation: sale-promotion-15.0/sale-promotion-15.0-sale_coupon_criteria_order_based Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-15-0/sale-promotion-15-0-sale_coupon_criteria_order_based/it/

Currently translated at 100.0% (7 of 7 strings) Translation: sale-promotion-15.0/sale-promotion-15.0-sale_coupon_criteria_order_based Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-15-0/sale-promotion-15-0-sale_coupon_criteria_order_based/es/

…tests This test requires a CoA to be installed, it should be tagged "post_install" TT46134

…based

mmequignon · 2024-10-25T13:17:35Z

ping @francesco-ooops @Ivorra78 @pilarvargas-tecnativa
could you please drop a review ?
Thanks!

francesco-ooops

Please check whether documentation is still accurate (eg: there's no "Sales/Products/Promotion Programs menu" in v17)
Domain button is not visible:

Also, is it correct that "Based on order" domain is both visible in promotion form and "conditional rules" popup?

mmequignon · 2024-10-25T14:31:44Z

Please check whether documentation is still accurate (eg: there's no "Sales/Products/Promotion Programs menu" in v17)

You're right, I totally forgot to update the doc

* Domain button is not visible:

Yes, adding it right now

* Also, is it correct that "Based on order" domain is both visible in promotion form and "conditional rules" popup?

Yes, and they are evaluated sequencially, which allows to have more complex rules.
1 domain which is common to all rules set on the program.
1 domain on the rule itself, which is specific to it.
With that we can imagine for a given program, the order should always be draft, 1 rule requires 10$ spent, the other a specific product to trigger the access to the reward.

francesco-ooops · 2024-10-25T15:25:18Z

@mmequignon that's good, what about adding to the doc also this explanation about the presence of the field in both the promo and the condition rule to make more explicit how it's supposed to work?

mmequignon · 2024-10-28T13:48:58Z

@francesco-ooops I updated the PR, can you please make another pass ?
Thanks !

francesco-ooops · 2024-10-28T13:58:36Z

@mmequignon ping me after tests are fixed :)

mmequignon · 2024-10-28T14:22:29Z

@mmequignon ping me after tests are fixed :)

@francesco-ooops done

francesco-ooops · 2024-10-28T14:28:12Z

@mmequignon mmm I don't see the field

mmequignon · 2024-10-28T14:33:05Z

@mmequignon mmm I don't see the field

That is because I added base.group_no_one (as it is done on product_domain) on the field.
you have to be have debug with assets enabled to see it

francesco-ooops · 2024-10-28T14:38:09Z

Well,

why?
that's the kind of stuff that makes functionals go to devs and ask "why don't I see this field?" and after their reply, "why isn't that in the documentation?"

I don't want to be rude, but our time is valuable too :)

mmequignon · 2024-10-28T14:42:42Z

Well,

1. why?

2. that's the kind of stuff that makes functionals go to devs and ask "why don't I see this field?" and after their reply, "why isn't that in the documentation?"

I don't want to be rude, but our time is valuable too :)

I see your point, I just thought it would be better to stick to what was done for product_domain.
I'll drop this groups attribute.

francesco-ooops

Functional ok!

francesco-ooops · 2024-10-28T15:39:35Z

just a suggestion: UX-wise, it would be useful if domain condition would be displayed in the "condition" card, in order to make all the rules explicit (as it happens for other fields)

mmequignon · 2024-10-28T15:58:35Z

just a suggestion: UX-wise, it would be useful if domain condition would be displayed in the "condition" card, in order to make all the rules explicit (as it happens for other fields)

I'll add this to the ROADMAP

grindtildeath

LGTM 👍

OCA-git-bot · 2024-10-28T19:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pilarvargas-tecnativa

The criteria cannot be applied at rule level and at program level. You have to decide at which level it should be applied and follow the odoo flow to apply a promotion and respect the changes that have been made since version 16.0 to adapt the promotion modules. You can check the 16.0 branch and see how other modules have been migrated for reference.

pilarvargas-tecnativa · 2024-10-28T15:22:56Z

sale_loyalty_criteria_order_based/models/loyalty_program.py

+class LoyaltyProgram(models.Model):
+    _inherit = "loyalty.program"
+
+    rule_order_domain = fields.Char(string="Based on Order", default="[]")


Where are you going to apply the criteria? At the rule level or at the program level?

pilarvargas-tecnativa · 2024-10-28T15:23:12Z

sale_loyalty_criteria_order_based/models/loyalty_rule.py

+class LoyaltyRule(models.Model):
+    _inherit = "loyalty.rule"
+
+    rule_order_domain = fields.Char(string="Based on Order", default="[]")


Where are you going to apply the criteria? At the rule level or at the program level?

grindtildeath · 2024-10-30T19:04:08Z

sale_loyalty_criteria_order_based/models/loyalty_program.py

+class LoyaltyProgram(models.Model):
+    _inherit = "loyalty.program"
+
+    rule_order_domain = fields.Char(string="Based on Order", default="[]")


Wouldn't it make more sense to use a M2o on ir.filter in order to make it reusable between different programs?

diga and others added 16 commits October 21, 2024 09:58

[14.0][ADD] sale_coupon_criteria_order_based

1f9da64

Added translation using Weblate (Italian)

fee4658

[MIG] sale_coupon_criteria_order_based: Migration to version 15.0

9c94b9a

TT38306

[UPD] Update sale_coupon_criteria_order_based.pot

0fa67aa

[UPD] README.rst

a5a574f

[UPD] README.rst

feaa8d9

Added translation using Weblate (Spanish)

a951990

[FIX] sale_coupon_criteria_order_based: Add tagged "post_install" to …

a843f27

…tests This test requires a CoA to be installed, it should be tagged "post_install" TT46134

[BOT] post-merge updates

580fb33

sale_coupon_criteria_order_based: Pre-commit

f4ce3bf

sale_coupon_criteria_order_based: Migration to 17.0

9d47bbb

sale_loyalty_criteria_order_based: rename sale_coupon_criteria_order_…

cffdf02

…based

francesco-ooops suggested changes Oct 25, 2024

View reviewed changes

mmequignon force-pushed the 17.0-mig-sale_coupon_criteria_order_based branch from ba0087c to 2726966 Compare October 28, 2024 13:47

mmequignon force-pushed the 17.0-mig-sale_coupon_criteria_order_based branch from 2726966 to a5fc044 Compare October 28, 2024 14:15

sale_loyalty_criteria_order_based: Adapt to 17.0 odoo changes

1a29aa7

mmequignon force-pushed the 17.0-mig-sale_coupon_criteria_order_based branch from a5fc044 to 1a29aa7 Compare October 28, 2024 14:44

francesco-ooops approved these changes Oct 28, 2024

View reviewed changes

grindtildeath approved these changes Oct 28, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Oct 28, 2024

pilarvargas-tecnativa suggested changes Oct 29, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Oct 29, 2024

grindtildeath reviewed Oct 30, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] sale_coupon_criteria_order_based #228

[17.0][MIG] sale_coupon_criteria_order_based #228

mmequignon commented Oct 21, 2024

mmequignon commented Oct 25, 2024

francesco-ooops left a comment •

edited

Loading

mmequignon commented Oct 25, 2024

francesco-ooops commented Oct 25, 2024

mmequignon commented Oct 28, 2024

francesco-ooops commented Oct 28, 2024

mmequignon commented Oct 28, 2024

francesco-ooops commented Oct 28, 2024

mmequignon commented Oct 28, 2024 •

edited

Loading

francesco-ooops commented Oct 28, 2024

mmequignon commented Oct 28, 2024

francesco-ooops left a comment

francesco-ooops commented Oct 28, 2024

mmequignon commented Oct 28, 2024

grindtildeath left a comment

OCA-git-bot commented Oct 28, 2024

pilarvargas-tecnativa left a comment

pilarvargas-tecnativa Oct 28, 2024

pilarvargas-tecnativa Oct 28, 2024

grindtildeath Oct 30, 2024

[17.0][MIG] sale_coupon_criteria_order_based #228

Are you sure you want to change the base?

[17.0][MIG] sale_coupon_criteria_order_based #228

Conversation

mmequignon commented Oct 21, 2024

mmequignon commented Oct 25, 2024

francesco-ooops left a comment • edited Loading

Choose a reason for hiding this comment

mmequignon commented Oct 25, 2024

francesco-ooops commented Oct 25, 2024

mmequignon commented Oct 28, 2024

francesco-ooops commented Oct 28, 2024

mmequignon commented Oct 28, 2024

francesco-ooops commented Oct 28, 2024

mmequignon commented Oct 28, 2024 • edited Loading

francesco-ooops commented Oct 28, 2024

mmequignon commented Oct 28, 2024

francesco-ooops left a comment

Choose a reason for hiding this comment

francesco-ooops commented Oct 28, 2024

mmequignon commented Oct 28, 2024

grindtildeath left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Oct 28, 2024

pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

pilarvargas-tecnativa Oct 28, 2024

Choose a reason for hiding this comment

pilarvargas-tecnativa Oct 28, 2024

Choose a reason for hiding this comment

grindtildeath Oct 30, 2024

Choose a reason for hiding this comment

francesco-ooops left a comment •

edited

Loading

mmequignon commented Oct 28, 2024 •

edited

Loading