[ADD] sale_loyalty_discount_attribute #97
Conversation
diogocsc
force-pushed
the
feat-dc-sale-loyalty-discount-attribute
branch
from
874df77
to
c8ff0e6
Compare
diogocsc
force-pushed
the
feat-dc-sale-loyalty-discount-attribute
branch
from
c8ff0e6
to
3dc2b2d
Compare
| class SaleOrder(models.Model): | ||
| _inherit = "sale.order" | ||
|
|
||
| def _get_reward_values_discount(self, reward, coupon, **kwargs): |
There was a problem hiding this comment.
@diogocsc Can you please add a test case for this?
There was a problem hiding this comment.
Added unit tests in later commit
| discount.update({"price_unit": price_unit}) | ||
| return_res.append(discount) | ||
|
|
||
| return return_res |
There was a problem hiding this comment.
My feeling is that it should return resand the return_Resvariable is not needed.
There was a problem hiding this comment.
Replaced in latest commit, using an index to update res.
… limit_discounted_attributes is False
| "price_unit": 10.0, | ||
| } | ||
|
|
||
| def setUp(self): |
There was a problem hiding this comment.
@diogocsc Could you change this to setUpClass ?
|
@diogocsc CI is red, can you check please? |
|
Seems like an odd pre-commit install error. Maybe with your new push the build gets green. |
| attributes_wise_price_unit = 0.0 | ||
| for so_lines in self.order_line.filtered( | ||
| lambda l: not l.reward_id | ||
| and l.product_id.id in reward.discount_product_ids.ids |
There was a problem hiding this comment.
@Nikul-OSI We can also pick a product Category. Would this work in that case?
There was a problem hiding this comment.
@dreispt No, This for only product which is selected on rewards.
Nikul-OSI
force-pushed
the
feat-dc-sale-loyalty-discount-attribute
branch
from
d7e9e7b
to
7e87530
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
No description provided.