Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] sale_order_report_product_image: Migration to 17.0 #283

Merged
merged 24 commits into from
Oct 4, 2024
Merged

[17.0][MIG] sale_order_report_product_image: Migration to 17.0 #283

merged 24 commits into from
Oct 4, 2024

Conversation

JoseIbarraHdz
Copy link

@JoseIbarraHdz JoseIbarraHdz commented Sep 19, 2024 •
edited
Loading

  • update version to 17.0.1.0.0

image

cubells and others added 22 commits September 19, 2024 00:02
@cubells @JoseIbarraHdz
[ADD] sale_order_report_product_image module
8458fbc
@rven @JoseIbarraHdz
[MIG] sale_order_report_product_image: Migration to 12.0
32d6483
@marylla @JoseIbarraHdz
Added translation using Weblate (German)
8e400e3
@marylla @JoseIbarraHdz
Translated using Weblate (German)
c0b3970 
Currently translated at 100.0% (1 of 1 strings)

Translation: sale-reporting-12.0/sale-reporting-12.0-sale_order_report_product_image
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-12-0/sale-reporting-12-0-sale_order_report_product_image/de/
@Borruso @JoseIbarraHdz
[IMP] sale_order_report_product_image: black, isort, prettier
c1cbe34
@Borruso @JoseIbarraHdz
[MIG] sale_order_report_product_image: Migration to 14.0
8dffef3
@francesco-ooops @JoseIbarraHdz
Added translation using Weblate (Italian)
2908a04
@francesco-ooops @JoseIbarraHdz
Translated using Weblate (Italian)
76ca0f5 
Currently translated at 100.0% (1 of 1 strings)

Translation: sale-reporting-14.0/sale-reporting-14.0-sale_order_report_product_image
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-14-0/sale-reporting-14-0-sale_order_report_product_image/it/
@ivantodorovich @JoseIbarraHdz
[IMP] sale_order_report_product_image: pre-commit execution
0972ccd
@ivantodorovich @JoseIbarraHdz
[MIG] sale_order_report_product_image: Migration to 15.0
9cb7e75
@ivantodorovich @JoseIbarraHdz
[IMP] sale_order_report_product_image: use named instead of positiona…
17b7220 
…l xpaths
@JesusValdez96 @JoseIbarraHdz
[IMP] sale_order_report_product_image: pre-commit stuff
6e7f1d7
@JesusValdez96 @JoseIbarraHdz
[MIG] sale_order_report_product_image: Migration to 16.0
5b9fea1
@JoseIbarraHdz
[UPD] Update sale_order_report_product_image.pot
f0dd4c7
@OCA-git-bot @JoseIbarraHdz
[UPD] README.rst
93bd96b
@weblate @JoseIbarraHdz
Update translation files
37f9d34 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-reporting-16.0/sale-reporting-16.0-sale_order_report_product_image
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-16-0/sale-reporting-16-0-sale_order_report_product_image/
@mymage @JoseIbarraHdz
Translated using Weblate (Italian)
8f1fce9 
Currently translated at 100.0% (1 of 1 strings)

Translation: sale-reporting-16.0/sale-reporting-16.0-sale_order_report_product_image
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-16-0/sale-reporting-16-0-sale_order_report_product_image/it/
@pedrocs-exo @JoseIbarraHdz
Added translation using Weblate (Portuguese)
3de1584
@pedrocs-exo @JoseIbarraHdz
Translated using Weblate (Portuguese)
5ec7227 
Currently translated at 100.0% (1 of 1 strings)

Translation: sale-reporting-16.0/sale-reporting-16.0-sale_order_report_product_image
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-16-0/sale-reporting-16-0-sale_order_report_product_image/pt/
@OCA-git-bot @JoseIbarraHdz
[UPD] README.rst
54323bd
@metingulsoy @JoseIbarraHdz
Added translation using Weblate (Turkish)
8226526
@metingulsoy @JoseIbarraHdz
Translated using Weblate (Turkish)
7f97dcf 
Currently translated at 100.0% (1 of 1 strings)

Translation: sale-reporting-16.0/sale-reporting-16.0-sale_order_report_product_image
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-16-0/sale-reporting-16-0-sale_order_report_product_image/tr/
@edy1192
Copy link

edy1192 commented Sep 19, 2024

Functional test LGTM 👍🏼

@JoseIbarraHdz JoseIbarraHdz mentioned this pull request Sep 19, 2024
Open
10 tasks
@edy1192
Copy link

edy1192 commented Sep 19, 2024

Hi @manuelregidor could you check this, please?

cc @JoseIbarraHdz

@manuelregidor
Copy link

@edy1192 You need to have two commits: one for the pre-commit auto fixes and another one for the migration itself.

antoniocanovas
antoniocanovas approved these changes Sep 24, 2024
View reviewed changes
Copy link

@antoniocanovas antoniocanovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK !!

@JoseIbarraHdz JoseIbarraHdz force-pushed the 17.0-mig-sale_order_report_product_image branch from 58ef741 to fb86423 Compare September 25, 2024 16:22
@JoseIbarraHdz
Copy link
Author

Hi @manuelregidor could you check this please? There are the two commits you mentioned above.

Regards.

cc. @edy1192

@JoseIbarraHdz JoseIbarraHdz force-pushed the 17.0-mig-sale_order_report_product_image branch from fb86423 to 27a23d2 Compare September 25, 2024 18:04
manuelregidor
manuelregidor approved these changes Sep 26, 2024
View reviewed changes
Copy link

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review. LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza
pedrobaeza requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mix of changes in commits: some of them should be on the migration commit (like the README ones), and some on the pre-commit auto-fixes.

pandoc-3.4-1-amd64.deb Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be present.

@JoseIbarraHdz JoseIbarraHdz force-pushed the 17.0-mig-sale_order_report_product_image branch from 27a23d2 to b16dc48 Compare September 30, 2024 18:08
@JoseIbarraHdz
Copy link
Author

Hi @pedrobaeza I did the changes you requested, can you please check?

pedrobaeza
pedrobaeza approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, there are still some mix of changes between commits, but for this time is enough. Please follow all the steps of the migration guide the next time for avoiding this kind of things.

/ocabot merge nobump

@JoseIbarraHdz
Copy link
Author

Hi @pedrobaeza thanks for the approval, I'll follow the guide steps next time, by the way, it is already merged?

Regards.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@pedrobaeza pedrobaeza changed the title [MIG] sale_order_report_product_image: Migration to 17.0 [17.0][MIG] sale_order_report_product_image: Migration to 17.0 Oct 4, 2024
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-283-by-pedrobaeza-bump-nobump, awaiting test results.

@pedrobaeza
Copy link
Member

/ocabot migration sale_order_report_product_image

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 4, 2024
@OCA-git-bot OCA-git-bot merged commit f4d2d56 into OCA:17.0 Oct 4, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d3d0613. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelregidor manuelregidor manuelregidor approved these changes

@antoniocanovas antoniocanovas antoniocanovas approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.