[14.0][IMP] sale_order_general_discount: apply discount product optin #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al discount apply product option
|
Hi @OCA/crm-sales-marketing-maintainers cc @sbidoul not sure what should we do to makes runboat happy on this repo ? is there already some stuff managed about this use case ? |
|
@petrus-v let's discuss handling of conflicting modules in runboat in sbidoul/runboat#36 |
ferran-S73
approved these changes
May 23, 2023
|
@sergio-teruel ping :) |
JordiMForgeFlow
approved these changes
Nov 18, 2023
|
As far I understand, someone else develop something similar that has been merged in the mean time #2685 using a domain in settings. So, I'm closing this PR ! Feel free to adapt it and create a new PR if you feel needs user be able to set it on product directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My customer has hundred lines in sale order, he wants apply discount only on some kind of products according his business rules. As today he set general discoung and move back to zero each lines manually.
The purpose of this PR is to improve
sale_order_general_discountmodule in order to add an option on product to define if the general discount should be applied on sale order lines according linked product.