[17.0][MIG] sale_automatic_workflow: Migration to 17.0

[trisdoan]

This change

• This PR separates the module stock from sale_automatic_workflow

[sebalix]

@trisdoan thank you. Can you rename your PR [17.0][MIG] sale_automatic_workflow and add the stock separation comment in the PR body instead?

[sebalix]

Better to use a simple comment to not replace the docstring of the original method

# Override to add stock related workflow

[sebalix]

Same, use comment instead of docstring

[sebalix]

Here too

[trisdoan]

Hello @sebalix, I updated as you suggest 🙏

[rousseldenis]

/ocabot migration sale_automatic_workflow

[OCA-git-bot]

The migration issue (#2766) has not been updated to reference the current pull request because a previous pull request (#2826) is not closed.
Perhaps you should check that there is no duplicate work.
CC @sanderlienaerts

[rousseldenis]

@trisdoan @sebalix Maybe it's time to change the field to computed/stored/readonly=False one to remove onchanges.

UPDATE: In fact, you should override the _compute_team_id() method and to add 'workflow_process_id' in depends.

[trisdoan]

Hello @rousseldenis @sebalix, I updated as you suggest

I added this commit.
I adapt field picking_policy in sale.order to writable computed field. Unfortunately, there is a module: sale_order_type, which does the same thing but depends on field 'type_id' instead.
-> So one solution is to mark sale_order_type as rebel module. What do you guys think?

[sebalix]

Not sure it's a good idea 🤔
What you could do is to extract the @api.depends values in a method and make use of hasattr like it's done in the compute method:

# in sale_order_type
def _depends_picking_policy(self):
    depends = []
    if hasattr(super(), "_depends_picking_policy"):
        depends = super()._depends_picking_policy()
    depends.append("type_id")
    return depends

@api.depends(lambda self: self._depends_picking_policy())
def _compute_picking_policy():
    [...]

# in sale_automatic_workflow_stock
def _depends_picking_policy(self):
    depends = []
    if hasattr(super(), "_depends_picking_policy"):
        depends = super()._depends_picking_policy()
    depends.append("workflow_process_id")
    return depends

@api.depends(lambda self: self._depends_picking_policy())
def _compute_picking_policy():
    [...]

This way we are dynamically compatible with both modules installed (and probably still with an undefined behavior, but that's better than something else I guess).

[sebalix]

@trisdoan any news about this?

[trisdoan]

commit is coming today. Will ping you when it's done

[trisdoan]

Hello @sebalix, updated as you suggest + tests are green 🙏

[trisdoan]

DRAFT: working on failed tests

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[gurneyalex]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-3105-by-gurneyalex-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 834b836. Thanks a lot for contributing to OCA. ❤️