Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] sale_order_line_date: commitment_date copy False #3377

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][IMP] sale_order_line_date: commitment_date copy False #3377

wants to merge 1 commit into from

Conversation

JoanSForgeFlow
Copy link
Contributor

PR in order to not copy delivery date of sale.order.line when duplicating

LoisRForgeFlow
LoisRForgeFlow approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this aligns the behavior with the commitment_date in the sale.order upstream, so we could even consider it a fix 👍

@JoanSForgeFlow JoanSForgeFlow force-pushed the 15.0-sale_order_line_date-copy-false branch from e4759bd to 1aae3b2 Compare October 28, 2024 09:22
@JoanSForgeFlow JoanSForgeFlow force-pushed the 15.0-sale_order_line_date-copy-false branch from 1aae3b2 to bbab91a Compare October 28, 2024 10:01
rrebollo
rrebollo reviewed Nov 3, 2024
View reviewed changes
Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean work!!!

LauraCForgeFlow
LauraCForgeFlow approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@LauraCForgeFlow LauraCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AaronHForgeFlow
AaronHForgeFlow approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@JordiBForgeFlow
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-3377-by-JordiBForgeFlow-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 5, 2024
@OCA-git-bot
Merge PR #3377 into 15.0
06ba6d0 
Signed-off-by JordiBForgeFlow
@OCA-git-bot
Copy link
Contributor

@JordiBForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-3377-by-JordiBForgeFlow-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@JoanSForgeFlow
Copy link
Contributor Author

@JordiBForgeFlow seems it has failed because a timeout. Could you try again?

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrebollo rrebollo rrebollo left review comments

@LauraCForgeFlow LauraCForgeFlow LauraCForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JoanSForgeFlow @OCA-git-bot @JordiBForgeFlow @AaronHForgeFlow @LoisRForgeFlow @MiquelRForgeFlow @rrebollo @LauraCForgeFlow