[15.0] [MIG]: sale_mrp_bom #3380
Conversation
|
/ocabot migration sale_mrp_bom |
|
@pedrobaeza sorry to bother U, the failing test is pointing to pre-commit stuff which aren't in the addon I'm upgrading so what can I do about it? |
|
That's because you have updated the copier template in this PR, and thus, new linter requirements. You have to either not update the copier template, or update it, and fix the linter new complaints. |
|
I've tested the module, and overall it performs well, as it does in other versions. However, I suggest enhancing the bom_id field by extending the domain to allow BOM selection only when the product is configured with the right routes. Specifically, the product should have either:
This improvement would help ensure that defining a BOM on the Sales Order leads to a Manufacturing Order upon confirmation (otherwise it only serves to have the reference), other, aligning with expected behavior. I noticed this feature isn’t present in v16 either, so this adjustment could done across versions. What do you think? |
I had to. The repo template has fixed node to v14 and it was raising eslint invalid syntax errors. Same for autoflake and flake8 hooks for pre-commit. The first one was raising "no module name distutils", the second one "AttributeError: 'EntryPoints' object has no attribute 'get'". I'll fix the pre-commit complaints. |
rrebollo
force-pushed
the
15.0-mig-sale_mrp_bom
branch
2 times, most recently
from
2fa79f1
to
6369eb3
Compare
|
LGTM, Can you squash the translation commits? |
…s from other companies
…d if new_start is empty TT51461
This commit fixes a bug where the module would not accept a BoM on a Sale Order Line if the product in question had multiple variants and the BoM did not specify a variant. Now, regardless of whether the product has multiple variants or not, if the variant is specified on the BoM, it must match the product on the Sale Order Line (like before), but if it's not specified, matching on the product template is enough.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-sale_mrp_bom Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_mrp_bom/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_mrp_bom Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_mrp_bom/es/
[IMP] update repo template to 1.27 and update flake8 for pre-commit [IMP] update autoflake for pre-commit
rrebollo
force-pushed
the
15.0-mig-sale_mrp_bom
branch
from
6369eb3
to
9260e05
Compare
Reusing work from #2234 . Currently refactoring tests.