Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] sale_order_type_confirm_message #3472

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[ADD] sale_order_type_confirm_message #3472

merged 1 commit into from
Dec 19, 2024

Conversation

Tisho99
Copy link

@Tisho99 Tisho99 commented Dec 9, 2024 •
edited
Loading

This module includes a validation step when confirming a sale order.

T-7009

@Tisho99 Tisho99 force-pushed the 17.0-add-sale_order_type_confirm_message branch 2 times, most recently from ba16f65 to c4fbab7 Compare December 10, 2024 11:50
@Tisho99 Tisho99 marked this pull request as ready for review December 10, 2024 12:22
@Tisho99
Copy link
Author

Tisho99 commented Dec 10, 2024

@HaraldPanten @ValentinVinagre @luis-ron

@rousseldenis rousseldenis added this to the 17.0 milestone Dec 10, 2024
rousseldenis
rousseldenis requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

sale_order_type_confirm_message/tests/test_sale_order_type_confirm_message.py Outdated Show resolved Hide resolved
sale_order_type_confirm_message/wizards/sale_order_type_confirm_message_wizard.py Outdated Show resolved Hide resolved
sale_order_type_confirm_message/tests/test_sale_order_type_confirm_message.py Outdated Show resolved Hide resolved
@Tisho99 Tisho99 force-pushed the 17.0-add-sale_order_type_confirm_message branch from c4fbab7 to 5c2591a Compare December 10, 2024 16:59
@Tisho99
Copy link
Author

Tisho99 commented Dec 10, 2024

@rousseldenis thaks for the review! Requested changes applied

luis-ron
luis-ron approved these changes Dec 11, 2024
View reviewed changes
Copy link

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: LGTM 👍🏻

@Tisho99 Tisho99 force-pushed the 17.0-add-sale_order_type_confirm_message branch from 5c2591a to 3be8ef7 Compare December 13, 2024 16:25
manuelregidor
manuelregidor approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ValentinVinagre
ValentinVinagre approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@HaraldPanten
Copy link
Contributor

@rousseldenis Have your requested changes been considered correctly, in order to merge this PR?

THX.

@Tisho99 Tisho99 force-pushed the 17.0-add-sale_order_type_confirm_message branch from 3be8ef7 to 1d9c2f4 Compare December 19, 2024 09:04
HaraldPanten
HaraldPanten requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to improve it's README

sale_order_type_confirm_message/readme/USAGE.md Outdated Show resolved Hide resolved
sale_order_type_confirm_message/readme/CONFIGURE.md Outdated Show resolved Hide resolved
@Tisho99 Tisho99 force-pushed the 17.0-add-sale_order_type_confirm_message branch from 1d9c2f4 to 8af17b7 Compare December 19, 2024 09:48
@HaraldPanten
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3472-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 07109b7 into OCA:17.0 Dec 19, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c5d3f96. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 17.0-add-sale_order_type_confirm_message branch December 19, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luis-ron luis-ron luis-ron approved these changes

@manuelregidor manuelregidor manuelregidor approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@ValentinVinagre ValentinVinagre ValentinVinagre approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Tisho99 @HaraldPanten @OCA-git-bot @rousseldenis @ValentinVinagre @manuelregidor @luis-ron