-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] sale_order_general_discount: Migration to 18.0 #3488
Open
HeliconiaSolutions
wants to merge
34
commits into
OCA:18.0
Choose a base branch
from
HeliconiaIO:18.0-mig-sale_order_general_discount
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] sale_order_general_discount: Migration to 18.0 #3488
HeliconiaSolutions
wants to merge
34
commits into
OCA:18.0
from
HeliconiaIO:18.0-mig-sale_order_general_discount
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt for all sale order lines
…nes created without UI form view
[MIG] Migrated sale_order_general_discount to v13. [IMP] Improved code as per request. [IMP][13.0] sale_order_general_discount: rebase with OCA/13.0 + apply pre-commit [UPD] sale_order_general_discount: update view to display percentage correctly
version conflict prevents upload to pypi
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_general_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_general_discount/it/
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_general_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_general_discount/pt_BR/
Set general discount as line discount only if there's a general discount.
It's not needed anymore. This is handled by the compute.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_general_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_general_discount/
…al discount apply product option
50 tasks
sheragar
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Funtional Review 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.