Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] sale_product_set_sale_by_packaging: Migration to 18.0 #3494

Open
wants to merge 19 commits into
base: 18.0
Choose a base branch
from

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Dec 16, 2024

Note

Changes in 18.0

  • can_be_sold is now replaced by standard Odoo field: sales, which was introduced from 15.0 in odoo/odoo@a2b207c
  • group_discount_per_so_line was moved to module sale in here odoo/odoo@82eb2b5
  • Make sell_only_by_packaging writable in object ProductSetLine to bypass oca-ci test
    • Without this, CI is sad due to this warning
    • The field is solely used in constraint, and nowhere in view, which should be fine to make it writable
  • sale_by_packaging was stopped to migrate since 15.0, sell_only_by_packaging was introduced to replace, in https://github.com/OCA/sale-workflow/pull/2623, which is migrated to 18.0 in

@trisdoan trisdoan force-pushed the 18.0-mig-sale_product_set_sale_by_packaging branch from 9d43c74 to e5f87ca Compare December 16, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants