[16.0][ADD] sale_order_blanket_order_sale_margin: Manage margin on call off orders #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_prebook Fixup: Validate call off lines on order confirmation only
…_prebook Fixup: Refactor to avoid duplicate code
…_prebook Fixup: Implements eol
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
… orders This module extends the functionality of the module sale_order_blanket_order and sale_margin to ensure that the margin calculation takes into account the specific case of cutt off orders. In the case of a cutt off order, the margin must be set to 0 since the financial impact of the order is managed on the blanket order.
lmignon
force-pushed
the
16.0-add-sale_order_blanket_order_sale_margin
branch
from
8437e3e to
4b3f384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module extends the functionality of the module sale_order_blanket_order and sale_margin to ensure that the margin calculation takes into account the specific case of cut off orders. In the case of a cut off order, the margin must be set to 0 since the financial impact of the order is managed on the blanket order.