Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] sale_fixed_discount: Fixed discount consideration for por… #3513

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

fd-oerp
Copy link
Contributor

@fd-oerp fd-oerp commented Dec 23, 2024

…tal orders

Issue:
When a pricelist is applied to a specific product with a discount, the discount is visible on the portal product page. However, during checkout, the discount is not reflected in the cart and is not considered in the total.
Attached is a screenshot showing how the discount was not reflected in the portal cart before this fix:
image

Fix:
The issue occurred because the module was calling the base method _compute_discount but did not call the super method, which resulted in this behavior. This has now been addressed with the fix in this commit.

Expected Behavior:
Products with discounts applied via pricelists will now correctly show the discount in the cart during checkout.
Attached is a screenshot showing how the discount is now correctly reflected in the cart after applying this fix :
image

@fd-oerp
Copy link
Contributor Author

fd-oerp commented Dec 23, 2024

Hi @rousseldenis

Could you please review this fix/PR and let me know if anything needs to be updated from my end?

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant