Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] server_environment from 17.0 #204

Merged
merged 87 commits into from
Oct 4, 2024

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Sep 30, 2024

First 18.0 PR to test the project template.

@sbidoul
Copy link
Member Author

sbidoul commented Sep 30, 2024

@moylop260 can you help with the po-pretty-format issue here? I don't understand what the error means.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 1, 2024

The other issue is that the current .eslintrc.yml is not compatible with the latest eslint, and eslint-precommit does not seem to work well with pre-commit...

@rousseldenis
Copy link
Contributor

@moylop260 can you help with the po-pretty-format issue here? I don't understand what the error means.

Currently on it.

Try regenerating .pot file.

@SirAionTech
Copy link

The other issue is that the current .eslintrc.yml is not compatible with the latest eslint, and eslint-precommit does not seem to work well with pre-commit...

Try including SirAionTech@d8e1926; I'll try to include it in the addons repo template in the next few days or more probably after the experience

@sbidoul
Copy link
Member Author

sbidoul commented Oct 2, 2024

@SirAionTech I worry that this adds additional dependencies that are not pinned.

I don't know, if we don't find a good solution soon, we'll start with the same eslint version as in 17. And we then have a year to modernize..

jgrandguillaume and others added 18 commits October 2, 2024 17:57
(lp:c2c-addons/6.1  rev 11)
(lp:c2c-addons/6.1  rev 28.1.1)
…t is the blessed target.

(lp:c2c-addons/6.1  rev 40.2.1)
(lp:c2c-addons/6.1  rev 45.1.4)
…TK client, because for 6.1 the web client is the blessed target.

(lp:c2c-addons/6.1  rev 116)
This fixes OCA/server-tools#125 because in some Ubuntu systems
lsb_release outputs to stderr as well as stdout. This message will be
printed to console, not logged nor shown among server infomation. That
way the message is lost and only pollutes unit tests output.
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
OCA-git-bot and others added 5 commits October 2, 2024 17:57
Revert "server_environment: Fix value assignation in compute from default"

This reverts commit 464f3ec which would
break other modules using server_environment.

The original issue must be fixed in mail_environment.
@sbidoul sbidoul force-pushed the 18.0-mig-server_environment-qgr-sbi branch from c3b2f7a to e5218e6 Compare October 2, 2024 15:57
@sbidoul sbidoul marked this pull request as ready for review October 2, 2024 16:03
@sbidoul
Copy link
Member Author

sbidoul commented Oct 2, 2024

🍏

@sbidoul
Copy link
Member Author

sbidoul commented Oct 2, 2024

Don't merge just yet, I need to restart the bot.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 2, 2024

Ok, bot is ready.

@moylop260
Copy link
Contributor

@sbidoul

@moylop260 can you help with the po-pretty-format issue here? I don't understand what the error means.

Checking...

@moylop260
Copy link
Contributor

moylop260 commented Oct 2, 2024

@sbidoul

It needs the following args in order to autofix it:

 - repo: https://github.com/OCA/odoo-pre-commit-hooks
     rev: v0.0.33
     hooks:
       - id: oca-checks-odoo-module
       - id: oca-checks-po
+        args:
+          - --fix

OFFTOPIC: BTW I will show the diff if the parameter is not defined for wrong-format

UPDATED: OCA/odoo-pre-commit-hooks#110

UPDATED2: Agree disabling it OCA/oca-addons-repo-template#274

@sbidoul sbidoul force-pushed the 18.0-mig-server_environment-qgr-sbi branch from e5218e6 to 8aa5fbb Compare October 4, 2024 07:21
@pedrobaeza
Copy link
Member

/ocabot migration server_environment

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 4, 2024
@OCA-git-bot
Copy link
Contributor

There's no issue in this repo with the title 'Migration to version 18.0' and the milestone 18.0, so not possible to add the comment.

@pedrobaeza
Copy link
Member

The pre-commit auto-fixes commit is after the migration commit, but not being critical, let's try to merge the module to see if any problem:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-204-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 75cfde5 into 18.0 Oct 4, 2024
7 checks passed
@OCA-git-bot OCA-git-bot deleted the 18.0-mig-server_environment-qgr-sbi branch October 4, 2024 07:41
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3ddab30. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.