Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] base_sequence_option: Migration to 17.0 #3009

Open
wants to merge 16 commits into
base: 17.0
Choose a base branch
from

Conversation

peluko00
Copy link

@peluko00 peluko00 commented Aug 6, 2024

@peluko00 peluko00 force-pushed the 17.0-mig-base_sequence_option branch from 74f4fb4 to ceb50ca Compare August 6, 2024 14:06
@peluko00
Copy link
Author

peluko00 commented Aug 6, 2024

Can you revise that one @gurneyalex?

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peluko00
Copy link
Author

peluko00 commented Nov 4, 2024

Couldyou review please @kittiu. Thanks!

@kittiu
Copy link
Member

kittiu commented Nov 10, 2024

Cc @Saran440 @ps-tubtim

</h1>
<group>
<group>
<field name="model" readonly="1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="model" readonly="1" />
<field name="model" />

Why you add readonly in this field? User can't select model

@peluko00 peluko00 force-pushed the 17.0-mig-base_sequence_option branch from ceb50ca to 7f4ea76 Compare November 12, 2024 09:54
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test 👍

@peluko00
Copy link
Author

Seems it's ready to merge @kittiu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.