-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] fetchmail_attach_from_folder: Migration to 17.0 #3071
Open
zamberjo
wants to merge
54
commits into
OCA:17.0
Choose a base branch
from
aurestic:17.0-mig-fetchmail_attach_from_folder
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] fetchmail_attach_from_folder: Migration to 17.0 #3071
zamberjo
wants to merge
54
commits into
OCA:17.0
from
aurestic:17.0-mig-fetchmail_attach_from_folder
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duplicates; don't break existing configurations
- handle situation that optional mail address componenents not present in mail - slight reorganisation of code to aid debugging and made pep8 compliant as well.
[IMP] more efficient sorting of algorithms [IMP] improve readability of help strings
from imap servers [IMP] clean up the folders' treeview
[IMP] also log when we're done with one folder
mails creates/objects matched [ADD] preliminary docstrings
issues with long running cron threads as rollback also releases the lock
[FIX] use mail_thread.message_parse in wizard
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
The key 'active' is deprecated and is a synonym for 'auto_install'. This addon should not be automatically installed.
Now it is impossible to confirm a connection to a imap server if there is a problem in one folder. This commit provides a new state field on the folder and e separate comfirm button per folder.
Also do not reset connection status on change of underlying folders.
Also possibility to reset state for folder.
Match algorithms other then 'odoo_standard' were not correctly dealt with in the migrated code. For these algorithms we restore the handling (but with improvements) that was present in the 10.0 version.
for the matching record.
zamberjo
force-pushed
the
17.0-mig-fetchmail_attach_from_folder
branch
from
October 14, 2024 07:45
fa91872
to
dbe887f
Compare
zamberjo
force-pushed
the
17.0-mig-fetchmail_attach_from_folder
branch
from
October 14, 2024 09:04
dbe887f
to
429b87b
Compare
anmarmo1
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review is ok
Yes, I will review it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @NL66278, if #3017 is accepted I add it.