Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] fetchmail_attach_from_folder: Migration to 17.0 #3071

Open
wants to merge 54 commits into
base: 17.0
Choose a base branch
from

Conversation

zamberjo
Copy link
Member

Ping @NL66278, if #3017 is accepted I add it.

hbrunn and others added 30 commits October 14, 2024 08:05
duplicates; don't break existing configurations
      - handle situation that optional mail address componenents not present in mail
      - slight reorganisation of code to aid debugging and made pep8 compliant as well.
[IMP] more efficient sorting of algorithms
[IMP] improve readability of help strings
from imap servers
[IMP] clean up the folders' treeview
[IMP] also log when we're done with one folder
mails creates/objects matched
[ADD] preliminary docstrings
issues with long running cron threads as rollback also releases the lock
[FIX] use mail_thread.message_parse in wizard
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
The key 'active' is deprecated and is a synonym for 'auto_install'.
This addon should not be automatically installed.
NL66278 and others added 21 commits October 14, 2024 09:36
Now it is impossible to confirm a connection to a imap server if there is a problem
in one folder. This commit provides a new state field on the folder and e separate
comfirm button per folder.
Also do not reset connection status on change of underlying folders.
Match algorithms other then 'odoo_standard' were not correctly dealt with in the migrated code. For
these algorithms we restore the handling (but with improvements) that was present in the 10.0 version.
@zamberjo zamberjo force-pushed the 17.0-mig-fetchmail_attach_from_folder branch from fa91872 to dbe887f Compare October 14, 2024 07:45
@zamberjo zamberjo marked this pull request as draft October 14, 2024 08:08
@zamberjo zamberjo force-pushed the 17.0-mig-fetchmail_attach_from_folder branch from dbe887f to 429b87b Compare October 14, 2024 09:04
@zamberjo zamberjo marked this pull request as ready for review October 14, 2024 09:12
@zamberjo zamberjo mentioned this pull request Oct 14, 2024
34 tasks
Copy link

@anmarmo1 anmarmo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review is ok

@NL66278
Copy link
Contributor

NL66278 commented Oct 21, 2024

@anmarmo1 Could you also look at #3017 ? Would be a pity if the migration does not contain this.

@anmarmo1
Copy link

Yes, I will review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.