Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] stock_picking_low_priority #1196

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][ADD] stock_picking_low_priority #1196

wants to merge 2 commits into from

Conversation

glitchov
Copy link
Contributor

@glitchov glitchov commented Jan 20, 2023 •
edited
Loading

This module reintriduces a 'Not urgent' low priority on stock_picking/stock_move

@glitchov glitchov force-pushed the 16.0-add-stock_picking_low_priority-hda branch from f404898 to 78956f9 Compare January 20, 2023 15:14
@glitchov glitchov changed the title [16.0][ADD] stock_picking_low_priotiy [16.0][ADD] stock_picking_low_priority Jan 20, 2023
@glitchov glitchov force-pushed the 16.0-add-stock_picking_low_priority-hda branch 2 times, most recently from e30af06 to 5af1c70 Compare January 23, 2023 08:59
@rousseldenis rousseldenis added this to the 16.0 milestone Jan 23, 2023
lmignon
lmignon reviewed Jan 23, 2023
View reviewed changes
stock_picking_low_priority/readme/CONTRIBUTORS.rst
@@ -0,0 +1,2 @@
* Nans Lefebvre <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glitchov You can remove Nans from the author....

lmignon
lmignon suggested changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glitchov Thank you for this addon. Some comments but seems to be on the right track.

@glitchov glitchov force-pushed the 16.0-add-stock_picking_low_priority-hda branch from 5af1c70 to 732ea00 Compare January 23, 2023 10:29
@lmignon
Copy link
Contributor

lmignon commented Jan 23, 2023

@glitchov tests are failing

@glitchov
Copy link
Contributor Author

I know. I've already changed a lot of things but they still fail on OCA but not locally...

@lmignon
Copy link
Contributor

lmignon commented Jan 23, 2023

@glitchov ok I'll take a look

@lmignon lmignon force-pushed the 16.0-add-stock_picking_low_priority-hda branch from abb08eb to d9e6c06 Compare January 23, 2023 16:18
lmignon
lmignon approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional tests

@lmignon
Copy link
Contributor

lmignon commented Jan 23, 2023

ping @glitchov @rousseldenis @jbaudoux

rousseldenis
rousseldenis approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code review

jbaudoux
jbaudoux approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis
rousseldenis reviewed Feb 9, 2023
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@rousseldenis
Copy link
Contributor

@glitchov

@glitchov glitchov force-pushed the 16.0-add-stock_picking_low_priority-hda branch from d9e6c06 to a3b368d Compare February 9, 2023 14:01
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 11, 2023
@rousseldenis rousseldenis force-pushed the 16.0-add-stock_picking_low_priority-hda branch from a3b368d to ffaa42c Compare June 12, 2023 06:40
@rousseldenis
Copy link
Contributor

rousseldenis commented Jun 12, 2023 •
edited
Loading

@glitchov Could you fix tests ?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 18, 2023
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 22, 2023
@github-actions github-actions bot closed this Dec 3, 2023
@jbaudoux jbaudoux reopened this Dec 3, 2023
@dreispt dreispt added needs fixing and removed needs review stale PR/Issue without recent activity, it'll be soon closed automatically. labels Dec 27, 2023
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 28, 2024
@github-actions github-actions bot closed this Jun 2, 2024
@jbaudoux jbaudoux added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jun 3, 2024
@jbaudoux jbaudoux reopened this Jun 3, 2024
@rousseldenis
Copy link
Contributor

@jbaudoux I'll look at tests for this

@rousseldenis rousseldenis force-pushed the 16.0-add-stock_picking_low_priority-hda branch 2 times, most recently from e0c34ed to 842b189 Compare June 4, 2024 09:55
jbaudoux
jbaudoux reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the changes to stock_move_priority_picking_assign in another PR as I don't see the link with the other new module

stock_move_priority_picking_assign/models/stock_picking.py Show resolved Hide resolved
@rousseldenis rousseldenis force-pushed the 16.0-add-stock_picking_low_priority-hda branch from 842b189 to 7586a22 Compare September 24, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
approved needs fixing no stale Use this label to prevent the automated stale action from closing this PR/Issue. ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@glitchov @lmignon @OCA-git-bot @rousseldenis @jbaudoux @dreispt