Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_line_returned_qty: Migration to 16.0 #1306

Closed
wants to merge 10 commits into from

Conversation

pausanchezqubiq
Copy link
Contributor

No description provided.

@pausanchezqubiq pausanchezqubiq mentioned this pull request Jun 6, 2023
69 tasks
@pausanchezqubiq pausanchezqubiq force-pushed the 16.0-mig-sale_line_returned_qty branch 2 times, most recently from 53a0efc to 2bfae10 Compare June 7, 2023 10:36
@rousseldenis
Copy link
Contributor

/ocabot migration sale_line_returned_qty

@@ -0,0 +1 @@
This module adds the returned quantity of sale order lines as a computed field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than a technical explanation, this should be more a functional one (what it does, where it is displayed).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rousseldenis, the description is updated.

@pausanchezqubiq pausanchezqubiq force-pushed the 16.0-mig-sale_line_returned_qty branch from cbc09ce to 7596f85 Compare June 7, 2023 11:54
@pausanchezqubiq pausanchezqubiq force-pushed the 16.0-mig-sale_line_returned_qty branch from 4b915a1 to 6d862b7 Compare June 7, 2023 11:57
@JSebastian7913
Copy link

Functional review done.

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Copy link

@chusamo chusamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pausanchezqubiq pausanchezqubiq deleted the 16.0-mig-sale_line_returned_qty branch June 7, 2023 15:45
@pausanchezqubiq
Copy link
Contributor Author

I uploaded it again at #1309 as the previous commits were not all there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants