[16.0][MIG] product_expiry_simple #1320
Conversation
|
/coabot migration product_expiry_simple |
|
/ocabot migration product_expiry_simple |
|
@alexis-via please, could you rebase? and check if all is green? 🍏 Thank you! |
alexis-via
force-pushed
the
16-mig-product_expiry_simple
branch
4 times, most recently
from
8f8953b
to
1651c61
Compare
|
@rafaelbn done |
|
|
@hparfr yes, it's intended ! |
|
@bosd here is an example for you when you have a module that is incompatible with another module of the same repo and you need to have the tests green. |
|
@sbidoul Do we have a solution for incompatible modules? I remember that if we want to keep runboat running, this kind of module should have its specific repository. |
|
/ocabot merge nobump |
|
Sorry @alexis-via you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
I am the declared maintainer of product_expiry_simple, cf https://github.com/OCA/stock-logistics-workflow/blob/14.0/product_expiry_simple/__manifest__.py |
|
Bots don't like being insulted. The reason is likely that this PR is modifying other stuff than the addon being migrated. |
@rousseldenis you may remember this: sbidoul/runboat#95 |
|
@alexis-via Could you rebase to move forward on this as runboat has now two databases (one with all modules, one just with 'base') ? |
|
/ocabot rebase |
|
@rafaelbn The rebase process failed, because command |
alexis-via
force-pushed
the
16-mig-product_expiry_simple
branch
from
1651c61
to
fd7953e
Compare
|
rebased |
…n the picking type Update FR translation
Fix bad decorator
Travis: exclude the module because it conflicts with product_expiry
alexis-via
force-pushed
the
16-mig-product_expiry_simple
branch
from
9f4116a
to
e0522c4
Compare
Field 'use_expiry_date' on product.template is now a computed field, like the native 'tracking' field.
alexis-via
force-pushed
the
16-mig-product_expiry_simple
branch
from
e0522c4
to
0218380
Compare
|
rebase done |
|
@alexis-via Could you just let me know what was blocking in tests to have this seggregated in separate test flow (as I see you use the 'use_expiry_date`for constraint checks, so it shouldn't block other tests? |
|
@rousseldenis either you install product_expiry OR product_expiry_simple, but not both ! In the manifest of product_expiry_simple, I added |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at f61f438. Thanks a lot for contributing to OCA. ❤️ |
I migrated the module in october 2022, but it seems that I forgot to make the PR... sorry about that.