Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] stock_picking_batch_extended: Migration to 16.0 #1353

Merged
merged 36 commits into from
Sep 8, 2023
Merged

[16.0] [MIG] stock_picking_batch_extended: Migration to 16.0 #1353

merged 36 commits into from
Sep 8, 2023

Conversation

RodrigoBM
Copy link
Contributor

issue #1101

@RodrigoBM RodrigoBM force-pushed the 16.0-mig-stock_picking_batch_extended branch 7 times, most recently from 017352e to e4c3309 Compare August 11, 2023 00:40
@RodrigoBM RodrigoBM changed the title [16.0] [MIG] stock_picking_batch_extended: Migration to 16.0 [WIP][16.0] [MIG] stock_picking_batch_extended: Migration to 16.0 Aug 11, 2023
xAdrianCif
xAdrianCif approved these changes Aug 11, 2023
View reviewed changes
Copy link

@xAdrianCif xAdrianCif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review ok, thank you for the job!

This was referenced Aug 11, 2023
Closed
Closed
@RodrigoBM RodrigoBM changed the title [WIP][16.0] [MIG] stock_picking_batch_extended: Migration to 16.0 [16.0] [MIG] stock_picking_batch_extended: Migration to 16.0 Aug 11, 2023
@FranciscoFactorLibre
Copy link
Contributor

I have reviewed, and I have seen two cases that I believe are not correct.

The first case is that when using several fields to create the batch, it only uses the first field, I attach a working video.

2023-08-14_13-21-56.mp4

The second case is that when using the option "Create picking batches grouped by fields" they always start in draft, without having the "draft" option checked, which I only see available in v16

Checking, in v15, the result is the same, does this result make sense? I think not, but I would like a second opinion.

@rafaelbn
Copy link
Member

Hello @RodrigoBM , please, could you 🙏🏼 delete an create a again the README according what this module makes or improve?

Actually and reviewing the README most of the things this module says make are already made by Odoo CE

Let me know please ! Thank you! ❤️

@oihane oihane mentioned this pull request Aug 30, 2023
Merged
@RodrigoBM RodrigoBM force-pushed the 16.0-mig-stock_picking_batch_extended branch from bfe6722 to 071f464 Compare August 30, 2023 16:22
@RodrigoBM
Copy link
Contributor Author

I have reviewed, and I have seen two cases that I believe are not correct.

The first case is that when using several fields to create the batch, it only uses the first field, I attach a working video.

2023-08-14_13-21-56.mp4
The second case is that when using the option "Create picking batches grouped by fields" they always start in draft, without having the "draft" option checked, which I only see available in v16

Checking, in v15, the result is the same, does this result make sense? I think not, but I would like a second opinion.

  • The first case is a bug that also exists in v15, this has been fixed.
  • The second case is an improvement added by odoo in v16, but I didn't have it in the code migration. This is now fixed

Iryna Vyshnevska and others added 13 commits August 30, 2023 18:35
@RodrigoBM
[FIX] stock_picking_mass_action return backorder if any of pickings n…
2864b75 
…eed it
@AdriaGForgeFlow @RodrigoBM
[12.0][FIX] stock_picking_batch_extended
f89c6f0
@pedrobaeza @RodrigoBM
[MIG] stock_picking_batch_extended: Migration scripts
d399619 
- Converts old stock.batch.picking in stock.picking.batch
- Restore link in stock.picking
- Other needed stuff
@carlosdauden @RodrigoBM
[FIX] stock_picking_batch_extended: float_is_zero required parameters
306c110
@carlosdauden @RodrigoBM
[IMP] stock_picking_batch_extended: UX improvements
9c53963
@carlosdauden @RodrigoBM
[IMP] stock_picking_batch_extended: Add followers, attachments, chatt…
2eedb3d 
…er and activities
@sergio-teruel @RodrigoBM
[IMP] stock_picking_batch_extended: Request confirmation to cancel pi…
04c3431 
…ckings
@pedrobaeza @RodrigoBM
[IMP] stock_picking_batch_extended: black, isort, prettier
8c65279
@sergio-teruel @RodrigoBM
[MIG] stock_picking_batch_extended: Migration to 13.0
51d72e9 
* Standard procedure
* Fix tests
@sergio-teruel @RodrigoBM
[IMP] stock_picking_batch_extended: Add kanban view in batch action f…
a388584 
…or small screens.
@OCA-git-bot @RodrigoBM
stock_picking_batch_extended 13.0.1.1.0
f3fec16
@carlosdauden @RodrigoBM
[IMP] stock_picking_batch_extended: Add optional picking_count column…
69d8a56 
… in tree view

TT28975
@OCA-git-bot @RodrigoBM
stock_picking_batch_extended 13.0.1.2.0
d4a887a
@RodrigoBM RodrigoBM force-pushed the 16.0-mig-stock_picking_batch_extended branch 2 times, most recently from 6064789 to b4e3151 Compare August 31, 2023 09:24
@RodrigoBM
Copy link
Contributor Author

Hello @RodrigoBM , please, could you 🙏🏼 delete an create a again the README according what this module makes or improve?

Actually and reviewing the README most of the things this module says make are already made by Odoo CE

Let me know please ! Thank you! ❤️

Done

@RodrigoBM
Copy link
Contributor Author

@oihane can you review this PR, thanks

oihane
oihane approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@oihane oihane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaelbn
Copy link
Member

rafaelbn commented Sep 1, 2023

/ocabot migration stock_picking_batch_extended

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 1, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 1, 2023
Open
65 tasks
@rafaelbn
Copy link
Member

rafaelbn commented Sep 1, 2023

I would like to review and write the new readme, simpler and with new screen shots

@RodrigoBM
Copy link
Contributor Author

I would like to review and write the new readme, simpler and with new screen shots

@rafaelbn I do it here

But if you want to propose other changes, send me a PR and I'll add it.

@RodrigoBM RodrigoBM force-pushed the 16.0-mig-stock_picking_batch_extended branch from b4e3151 to b073d4b Compare September 5, 2023 11:15
@RodrigoBM RodrigoBM force-pushed the 16.0-mig-stock_picking_batch_extended branch from b073d4b to e840e87 Compare September 5, 2023 11:18
@FranciscoFactorLibre
Copy link
Contributor

I have reviewed the functionality after the last update, and I see it working correctly.

image

I have generated several delivery notes that have different destinations and contacts:

When generating the batch, I used these two fields, as grouping options,
and created the groupings based on those criteria:

2023-09-05.16-12-31.mp4

rafaelbn
rafaelbn approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! 👍🏼

@rafaelbn
Copy link
Member

rafaelbn commented Sep 8, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1353-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d64b138 into OCA:16.0 Sep 8, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7213177. Thanks a lot for contributing to OCA. ❤️

@RodrigoBM RodrigoBM deleted the 16.0-mig-stock_picking_batch_extended branch September 8, 2023 07:52
FrancoMaxime
FrancoMaxime reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xAdrianCif @RodrigoBM With a little delay, Nice work.

@rafaelbn
Copy link
Member

@RodrigoBM all the images in the readme are broken, do you think you can fix them? You can checkit in github or runboat, they don't work. 😢

@RodrigoBM RodrigoBM mentioned this pull request Oct 17, 2023
Merged
@RodrigoBM
Copy link
Contributor Author

@RodrigoBM all the images in the readme are broken, do you think you can fix them? You can checkit in github or runboat, they don't work. 😢

urls fixed #1399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancoMaxime FrancoMaxime FrancoMaxime left review comments

@oihane oihane oihane approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@xAdrianCif xAdrianCif xAdrianCif approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.