Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] stock_valuation_fifo_lot #1527

Closed

Conversation

Saran440
Copy link
Member

@Saran440 Saran440 commented Mar 5, 2024

No description provided.

AungKoKoLin1997 pushed a commit to qrtl/stock-logistics-workflow that referenced this pull request May 17, 2024
when using an uom on move line which is different from product uom
new field introduced in v16 reserved_uom_qty
"""Hook function for other sort by"""
return all_candidates

def _get_all_candidates(self, company, sort_by=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In odoo 16, we have this kind of function https://github.com/odoo/odoo/blob/4d154a9f08cb2204df8566ed5c1e4f5e59e5d212/addons/stock_account/models/product.py#L331.
Should we extend and passing sort_by as a context?

@rousseldenis
Copy link
Contributor

@Saran440 Do you mind if we switch to #1676 ?

@Saran440
Copy link
Member Author

Saran440 commented Sep 5, 2024

No, go ahead.

@Saran440 Saran440 closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants