Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] storage_backend_sftp: Migration to 16.0 #241

Merged
merged 51 commits into from
Feb 9, 2024
Merged

[16.0][MIG] storage_backend_sftp: Migration to 16.0 #241

merged 51 commits into from
Feb 9, 2024

Conversation

santostelmo
Copy link
Contributor

@santostelmo santostelmo commented Feb 24, 2023 •
edited by simahawk
Loading

Migration of storage_backend_sftp to 16.0

ref: SOM-123

simahawk
simahawk requested changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rewrite the commit msg as [MIG] storage_backend_sftp: Migration to 16.0

storage_backend_sftp/__manifest__.py Outdated
{
"name": "Storage Backend SFTP",
"summary": "Implement SFTP Storage",
"version": "16.0.1.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "16.0.1.0.2",
"version": "16.0.1.0.0",

@simahawk simahawk mentioned this pull request Feb 24, 2023
Closed
@santostelmo santostelmo force-pushed the 16.0-mig-storage_backend_sftp branch 2 times, most recently from 53cd60d to ef56fdc Compare February 27, 2023 07:14
@santostelmo
Copy link
Contributor Author

please rewrite the commit msg as [MIG] storage_backend_sftp: Migration to 16.0

done

@bealdav
Copy link
Member

bealdav commented Mar 23, 2023 •
edited
Loading

@simahawk finally message commit rename with your expectations. Final review ?

@MiquelRForgeFlow
Copy link

Please cherry-pick cd5edda, which was merged in v15.

@yvaucher
Copy link
Member

/ocabot migration storage_backend_sftp

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 23, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request May 23, 2023
Open
5 tasks
@lmignon
Copy link
Sponsor Contributor

lmignon commented Aug 21, 2023

A rewrite of the storage_backend_* is proposed as a single addon supporting a wider list of platform through the use of the fsscpec python lib. You can take a look here #252 and #251

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 24, 2023
@github-actions github-actions bot closed this Jan 28, 2024
@gurneyalex gurneyalex reopened this Feb 9, 2024
@gurneyalex
Copy link
Member

@MiquelRForgeFlow The fix you are mentioning is on a different addon (storage_backend_ftp)

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

@gurneyalex The merge process could not start, because command `git merge --no-ff -m 'Merge PR #241 into 16.0

Signed-off-by gurneyalex' tmp-pr-241` failed with output:

CONFLICT (add/add): Merge conflict in requirements.txt
Auto-merging requirements.txt
Automatic merge failed; fix conflicts and then commit the result.

simahawk and others added 22 commits February 9, 2024 12:15
@simahawk @gurneyalex
storage_backend|_sftp: add test for find_files
65ccbd3
@simahawk @gurneyalex
storage_backend_sftp: add test for move_files
f626cb3
@simahawk @gurneyalex
storage_backend_sftp bump 13.0.1.2.0
f2e32a3
@simahawk @gurneyalex
storage_backend_sftp: use public api
bd56100
@OCA-git-bot @gurneyalex
storage_backend_sftp 13.0.1.3.0
7dbb092
@sebastienbeau @gurneyalex
[ADD] add new V14 config
c10571d
@sebastienbeau @gurneyalex
[IMP] all: black, isort, prettier
b677a26
@sebastienbeau @gurneyalex
[MIG] batch migration of modules
000428f
@OCA-git-bot @gurneyalex
storage_backend_sftp 14.0.1.0.1
7fd32f6
@oca-travis @gurneyalex
[UPD] Update storage_backend_sftp.pot
882cd94
@etobella @gurneyalex
[CHG] storage: Use more permissive licence: AGPL-> LGPL
9e9c4e0
@OCA-git-bot @gurneyalex
storage_backend_sftp 14.0.2.0.0
0f4989e
@acsonefho @gurneyalex
[13.0][ADD] storage_backend_ftp
626c2ca
@oca-travis @gurneyalex
[UPD] Update storage_backend_sftp.pot
3d1c0ec
@OCA-git-bot @gurneyalex
storage_backend_sftp 14.0.2.0.1
21e59e2
@i-vyshnevska @gurneyalex
[MIG][15.0] storage_backend_sftp
5591ec3
@SilvioC2C @gurneyalex
[FIX] storage_backend_sftp: use full path in move_files()
9c9c7ae
@gurneyalex
[UPD] Update storage_backend_sftp.pot
9a5f710
@OCA-git-bot @gurneyalex
storage_backend_sftp 15.0.1.0.1
2ad314e
@jcoux @gurneyalex
storage_backend_sftp: Fix paramiko usage
d87f35b 
Previous code used the paramiko client open function with explicit binary mode.

But, the explicit binary mode is now ignored by python.
See the `open` function description into the paramiko documentation:
https://docs.paramiko.org/en/stable/api/sftp.html

```
The Python 'b' flag is ignored, since SSH treats all files as binary.
```

But in fact, depending of the SFTP server we have an `OSError`.

Then this PR remove the useless binary mode, and avoid to have errors.
@OCA-git-bot @gurneyalex
storage_backend_sftp 15.0.1.0.2
f674b85
@santostelmo @gurneyalex
[MIG] storage_backend_sftp: Migration to 16.0
10ac638
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-241-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 43eb7e1 into OCA:16.0 Feb 9, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8348f04. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk requested changes

@gurneyalex gurneyalex gurneyalex approved these changes

@leemannd leemannd leemannd approved these changes

Assignees
No one assigned
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.