Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] fs_file: New field to store files #261

Merged
merged 3 commits into from
Aug 24, 2023
Merged

[16.0][ADD] fs_file: New field to store files #261

merged 3 commits into from
Aug 24, 2023

Conversation

lmignon
Copy link
Sponsor Contributor

@lmignon lmignon commented Apr 27, 2023 •
edited
Loading

TODO:

  • Add dedicated field widget
  • Removes the field_filename property (unused since I find a way to always pass the filename)
  • Improves implementation to avoid unnecessary load of content into memory
  • Add more documentation

@lmignon lmignon mentioned this pull request May 23, 2023
Merged
@lmignon lmignon force-pushed the 16.0-refactoring-rfc-fs_file-lmi branch from ff33f10 to 7230e94 Compare August 2, 2023 14:37
@marielejeune marielejeune force-pushed the 16.0-refactoring-rfc-fs_file-lmi branch 4 times, most recently from 951ff52 to c58dc0e Compare August 3, 2023 15:09
This was referenced Aug 21, 2023
Closed
Closed
@lmignon lmignon force-pushed the 16.0-refactoring-rfc-fs_file-lmi branch from c58dc0e to b277826 Compare August 23, 2023 11:44
@lmignon lmignon force-pushed the 16.0-refactoring-rfc-fs_file-lmi branch from b277826 to 556c2ef Compare August 24, 2023 11:35
@lmignon lmignon marked this pull request as ready for review August 24, 2023 11:37
@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Aug 24, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-261-by-lmignon-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6338522 into OCA:16.0 Aug 24, 2023
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2c62923. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-refactoring-rfc-fs_file-lmi branch August 24, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmignon @OCA-git-bot @marielejeune