Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] storage_image: Add a wizard to replace related file #273

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

mmequignon
Copy link
Member

Adds a wizard on the image form to replace the attached file.

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement :)

Can you

  1. add the wizard to storage_media too
  2. drop the onchange approach
  3. split commit by module
  4. drop the funny image
  5. fix pre-commit

please? 😄

storage_file/wizards/replace_file.py Outdated Show resolved Hide resolved
@mmequignon mmequignon force-pushed the 14.0-storage_image_replace_file branch from d41ea04 to c0a397e Compare August 24, 2023 11:00
@mmequignon
Copy link
Member Author

Thanks for the improvement :)

Can you

1. add the wizard to storage_media too

2. drop the onchange approach

3. split commit by module

4. drop the funny image

5. fix pre-commit

please? 😄

baaah, you're not funny

@mmequignon mmequignon force-pushed the 14.0-storage_image_replace_file branch 2 times, most recently from 6116a51 to 501fc5e Compare August 24, 2023 13:11
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, pls drop the icon. It's automatically generated ;)

Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests directory are missing an __init__.py file

storage_file/wizards/replace_file.py Outdated Show resolved Hide resolved
@mmequignon mmequignon force-pushed the 14.0-storage_image_replace_file branch from 501fc5e to 74456d8 Compare August 29, 2023 09:24
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 31, 2023
@github-actions github-actions bot closed this Feb 4, 2024
@simahawk simahawk reopened this Jul 12, 2024
@simahawk simahawk removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 12, 2024
@simahawk
Copy link
Contributor

@TDu could you update your review pls?

@simahawk
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-273-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9b82045 into OCA:14.0 Jul 15, 2024
12 of 13 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5b6492c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants