Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [MIG] website_crm_privacy_policy #1034

Open
wants to merge 31 commits into
base: 17.0
Choose a base branch
from

Conversation

sbiosca-s73
Copy link

Migration website_crm_privacy_policy to 17.0

antespi and others added 29 commits February 15, 2024 11:07
- Fix review comments
- Icon changed
- Remove website_legal_page depedency
- Set Privacy policy link for opening in new tab, in order to not change user focus and avoid losing any data entered by user in contactus form
- [IMP] README and OCA as author

OCA Transbot updated translations from Transifex
New `website_form` addon includes an undocumented validation system.
By simply adapting layout to what it wants, we get validation for free.
[UPD] Update website_crm_privacy_policy.pot
[UPD] Update website_crm_privacy_policy.pot

[UPD] README.rst
[UPD] Update website_crm_privacy_policy.pot

[UPD] README.rst

[UPD] README.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-16.0/website-16.0-website_crm_privacy_policy
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_crm_privacy_policy/
Currently translated at 100.0% (1 of 1 strings)

Translation: website-16.0/website-16.0-website_crm_privacy_policy
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_crm_privacy_policy/es/
The legal terms acceptance checkbox container had incompatible classes
with the editor that caused a property access error. This prevented
the text or link from being edited. This has been fixed to avoid
incompatibilities with the editor itself and with other modules such as
website_form_require_legal which adds the same functionality of
accepting terms for forms.

TT45834
Currently translated at 100.0% (1 of 1 strings)

Translation: website-16.0/website-16.0-website_crm_privacy_policy
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_crm_privacy_policy/it/
@sbiosca-s73 sbiosca-s73 force-pushed the 17.0-mig-website_crm_privacy_policy branch from db09144 to 5b50ee7 Compare February 20, 2024 14:29
@sbiosca-s73 sbiosca-s73 force-pushed the 17.0-mig-website_crm_privacy_policy branch from 5b50ee7 to d89596f Compare February 20, 2024 14:53
@sbiosca-s73 sbiosca-s73 force-pushed the 17.0-mig-website_crm_privacy_policy branch from d89596f to d2280c1 Compare February 20, 2024 14:55
@sbiosca-s73 sbiosca-s73 force-pushed the 17.0-mig-website_crm_privacy_policy branch from 11d8f51 to 3d30de7 Compare May 2, 2024 14:01
Copy link

github-actions bot commented Sep 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@sbiosca-s73
Copy link
Author

@pedrobaeza please put "no stale" label

@pedrobaeza
Copy link
Member

Instead, please enroll reviewers. Anyway, this one should be rebased and remove the dependency.

/ocabot migration website_crm_privacy_policy

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Sep 2, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 2, 2024
14 tasks
@sbiosca-s73
Copy link
Author

@antespi please review the code

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.