Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] website_snippet_big_button: Migration to version 17.0 #1072

Merged
merged 20 commits into from
Nov 28, 2024

Conversation

pilarvargas-tecnativa
Copy link

cc @Tecnativa TT51977

@chienandalu @CarlosRoca13 please review

Jairo Llopis and others added 20 commits November 28, 2024 15:14
- Delete CSS source.
- Use new snippets & snippet options API.
- New JS API.
- Follow guidelines and put templates under `templates/`
- LGPL.
- Remove usage of CSS grid. Too new for some browsers.
- Use flexbox instead to allow full responsiveness.
- Do not use block elements inside inline ones. Use classes `d-block` and `h3` instead.
- Fix wrapping issue.
- Do not use readable class; now it gets close to the same results giving more flexibility to the user.
Currently translated at 0.0% (0 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/fr/
Without this patch, a big button with a lot of content will fail to
render properly in phones.
Currently translated at 100.0% (2 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/pt_BR/
Currently translated at 50.0% (1 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/hr/
Currently translated at 100.0% (2 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/sl/
Currently translated at 100.0% (2 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/es/
Currently translated at 100.0% (2 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/ca/
Currently translated at 100.0% (2 of 2 strings)

Translation: website-12.0/website-12.0-website_snippet_big_button
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_big_button/fr/
Default links should not be set so that a user can edit where each
button should redirect to so that in case of not editing the link
there are no default redirects.

TT41033
@pedrobaeza
Copy link
Member

/ocabot migration website_snippet_big_button

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 28, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 28, 2024
14 tasks
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1072-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ba10a00. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 72efb3a into OCA:17.0 Nov 28, 2024
7 checks passed
@pedrobaeza pedrobaeza deleted the 17.0-mig-website_snippet_big_button branch November 28, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.