-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] shopfloor_base: add svg icon #375
Conversation
SVG should be there but not used in the menu AFAIK. |
I confirm. We need png in the menu. Having the SVG is still handy when we need to edit the image or scale it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restore png
Well, Odoo is doing the reverse move, finally using svg for menus. |
Thanks for update. As this is true in master branch, while this PR is addressed to odoo v14.0 I would arg to keep the .png in menu entry. As both file will be present in the repo after merging this branch moving to svg file will be easy in v16.0 ! |
d93c32a
to
bd0af1a
Compare
I've regenerate the png from the svg file and squashed my commits to avoid extra file in the history (first one was 400px per 400px)... |
Just realized that the shadow should be to the bottom left (not right)... likes other icons: |
bd0af1a
to
69557c1
Compare
You can check this icon generator: although SVG is a bit more tricky |
here you are, inspired from odoo icon I've also add another shadow about 5px (in 400x400 image) to the bottom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice Icon ;-)
This PR has the |
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 1bc1fcf. Thanks a lot for contributing to OCA. ❤️ |
as mentioned here: #319 (comment) convert the PNG image to SVG