Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] shopfloor_base: add svg icon #375

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

petrus-v
Copy link
Contributor

@petrus-v petrus-v commented Feb 16, 2022

as mentioned here: #319 (comment) convert the PNG image to SVG

@petrus-v
Copy link
Contributor Author

@simahawk @sebalix you give me the energie to use inskape to convert the image to SVG ! I'haven't test in odoo this PR using this svg image should probably test with the oca responsive module I suppose before merging !

@petrus-v
Copy link
Contributor Author

petrus-v commented Feb 16, 2022

also I'm not sure how to properly reference in app kanban view

image

(I'm loving new runboat, so fast ❤️ )

I'should probably let the .png as well ?

@simahawk
Copy link
Contributor

simahawk commented Feb 16, 2022

SVG should be there but not used in the menu AFAIK.
I can test.

@simahawk
Copy link
Contributor

I confirm. We need png in the menu. Having the SVG is still handy when we need to edit the image or scale it.

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restore png

@simahawk simahawk changed the title [14.0] shopflor_base: use svg icon instead png [14.0] shopfloor_base: add svg icon Feb 16, 2022
@pedrobaeza
Copy link
Member

Well, Odoo is doing the reverse move, finally using svg for menus.

@petrus-v
Copy link
Contributor Author

Well, Odoo is doing the reverse move, finally using svg for menus.

Thanks for update. As this is true in master branch, while this PR is addressed to odoo v14.0 I would arg to keep the .png in menu entry. As both file will be present in the repo after merging this branch moving to svg file will be easy in v16.0 !

@petrus-v
Copy link
Contributor Author

restore png

I've regenerate the png from the svg file and squashed my commits to avoid extra file in the history (first one was 400px per 400px)...

@petrus-v
Copy link
Contributor Author

@pedrobaeza
Copy link
Member

You can check this icon generator:

OCA/maintainer-tools#491

although SVG is a bit more tricky

@petrus-v
Copy link
Contributor Author

here you are, inspired from odoo icon I've also add another shadow about 5px (in 400x400 image) to the bottom

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice Icon ;-)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-375-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 91e99a5 into OCA:14.0 Mar 11, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1bc1fcf. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants