Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAPI-263 P-Code length conversion for higher admin levels #29

Merged
merged 10 commits into from
Nov 1, 2023
Merged

HAPI-263 P-Code length conversion for higher admin levels #29

merged 10 commits into from
Nov 1, 2023

Conversation

mcarans
Copy link
Contributor

@mcarans mcarans commented Oct 31, 2023

No description provided.

@mcarans mcarans requested a review from b-j-mills October 31, 2023 04:55
@github-actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Test Results

25 tests  +1   25 ✔️ +1   1m 47s ⏱️ +7s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e8be773. ± Comparison against base commit cf80895.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Oct 31, 2023 •
edited
Loading

Coverage Status

coverage: 98.932% (+0.1%) from 98.792% when pulling e8be773 on pcode_formats into cf80895 on main.

@mcarans mcarans changed the title Pcode formats HAPI-263 Pcode formats Oct 31, 2023
@mcarans mcarans changed the title HAPI-263 Pcode formats HAPI-263 P-Code length conversion for higher admin levels Oct 31, 2023
Mike added 2 commits November 2, 2023 10:39
Increase robustness - check string format looks like a p-code before …
761cb36 
…attempting processing as a p-code, uppercase p-codes, don't fuzzy match p-codes.
Increase robustness - check string format looks like a p-code before …
e8be773 
…attempting processing as a p-code, uppercase p-codes, don't fuzzy match p-codes.
@mcarans mcarans merged commit 3e54e8f into main Nov 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-mills b-j-mills b-j-mills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcarans @coveralls @b-j-mills