Add iso to fuzzy dont #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcarans
approved these changes
Oct 16, 2024
| if value not in relevant_admin_fuzzy_dont: | ||
| relevant_admin_fuzzy_dont.append(value) | ||
| continue | ||
| prefix, name = value.split("|") |
There was a problem hiding this comment.
I think it would be better if this matched by parent as well (where parent could be adm1 for adm2 for example), but if you need this urgently then this could be changed in a separate PR. What do you think? That is the logic in get_admin_name_replacements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new function to parse the admin_fuzzy_dont values. I made the iso code optional so it would be backward compatible with the values we've already added and we wouldn't have to track down the country each one came from.