Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data directory structure info to the readme #77

Merged
merged 1 commit into from
May 21, 2021

Conversation

turnerm
Copy link
Member

@turnerm turnerm commented May 13, 2021

No description provided.

@turnerm turnerm requested a review from Tinkaa May 13, 2021 12:07
Copy link
Contributor

@Tinkaa Tinkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After changing the link, it is good to go

Sync [this](https://drive.google.com/drive/u/3/folders/1RVpnCUpxHQ-jokV_27xLRqOs6qR_8mqQ)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to link to the Data directory instead of the Data/public? For now none of the dirs is openly accessible yet, but we should change this link

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll update the link!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I realized that if we change the link, we also need to change the instructions to say that the environment variable should go to the directory right above public, which complicates the set up a bit for external users. Do you know if there is any way we can provide the link to Data, but make sure that nothing in private is accessible?

Copy link
Contributor

@Tinkaa Tinkaa May 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm again good point..

Do you know if there is any way we can provide the link to Data, but make sure that nothing in private is accessible?

I wouldn't logically expect this to be possible and Googling doesn't show an answer. Would you know any way?
Else another approach might be to have two env variables, AA_DATA_DIR_PUBLIC and AA_DATA_DIR_PRIVATE? would require us to change part of the paths again but might cover all use cases (or if we have a more genaralised config we can maybe have an even easier method)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened issue #80 to tackle this, keeping the text as-is in the meantime.

@turnerm turnerm merged commit 1589deb into develop May 21, 2021
@Tinkaa Tinkaa deleted the feature/gdrive-structure-documentation branch May 24, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants