Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Don't log to stderr / stdout #344

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

M3ssman
Copy link
Contributor

@M3ssman M3ssman commented Sep 16, 2024

Description

The main rationale behind this PR is to replace any usage of System.err.println or System.out.println by a dedicated Logger to be able to persist those information for later investigation in case of errors.

The Logging uses slf4j-api and the implementation of ch.qos.logback , since the latter is preferred by the spring framework which is used throughout the actual service implementation.

Sample logging configuration included at src/main/webapp/resources/logback.xml.

@M3ssman
Copy link
Contributor Author

M3ssman commented Sep 18, 2024

The subsequent commit handles a strange effect when LAREX_VERSION is not set in environment, since this isn't the case in our context. Btw, how do you set this? At Tomcat startup?

@maxnth maxnth added Type: Enhancement Indicates an enhancement proposal for an existing feature Status: Confirmed Indicates an issue that was accepted by the contributors labels Sep 23, 2024
@maxnth maxnth changed the base branch from master to dev September 23, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed Indicates an issue that was accepted by the contributors Type: Enhancement Indicates an enhancement proposal for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants