Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing test #25

Merged
merged 12 commits into from
Feb 9, 2024
Merged

Fixing test #25

merged 12 commits into from
Feb 9, 2024

Conversation

hernoufM
Copy link
Collaborator

This PR aims to fix and to stabilize current tests

@hernoufM hernoufM requested a review from rjbou December 19, 2023 15:14
@hernoufM hernoufM mentioned this pull request Dec 19, 2023
@rjbou
Copy link
Collaborator

rjbou commented Dec 19, 2023

what is the difference between test 3 & 4 ?

@rjbou
Copy link
Collaborator

rjbou commented Dec 19, 2023

test 3: is there a reason to keep wxs if you don't print them ?

@hernoufM
Copy link
Collaborator Author

what is the difference between test 3 & 4 ?

Ah, actually no difference. I ll remove on of them

@hernoufM
Copy link
Collaborator Author

test 3: is there a reason to keep wxs if you don't print them ?

you are right, i ll remove it also

Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the ci issue, lgtm

@rjbou
Copy link
Collaborator

rjbou commented Feb 9, 2024

Tested tests locally, all green

@rjbou rjbou merged commit 1533271 into OCamlPro:master Feb 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants