Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more explanations on settings #367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GitMensch
Copy link

and back-reference for "show copybooks on hover"

this originates on me wondering why it did not work "as suggested by the README".

Question: Wouldn't it be reasonable for the LSP to have a list of the file names and if there's only a single one to match the copybook for hover/show definition`?
This would lead to most environments working "out of the box".

and back-reference for "show copybooks on hover"
@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024

CLA assistant check
All committers have signed the CLA.

@GitMensch
Copy link
Author

GitMensch commented Sep 3, 2024

requesting review from @nberth - feel free to move those changes to a different file in the case of generated package.json; but note that the "special line breaks" double+space, then lf do an "actual" line break, so those should be kept

a list, where each entry describes a file extension if the copybook name cannot
be found as-is (for example `COPY "mycpy.lib"`).
In SuperBOL, the `default` option does not correspond to GnuCOBOL's default, but to "cpy" and
"cbx" only.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is GnuCOBOL's default list actually cpy cbl cob as hinted here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, first in upper, then in lower-case

@GitMensch
Copy link
Author

@nberth: any updates on this? I'm not sure if #368 is likely to be finished soon and have a "frontend" in the vscode extension (it definitely sounds interesting), but with all the other important changes since the last release I'd like to see 0.1.4 going out "rather soon" - and thise one seems like a low hanging fruit before...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants